From 073ad077671b1c94ba4970226d8d05d1218cdbc4 Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Wed, 9 Oct 2019 02:47:34 -0400 Subject: [PATCH] Use ORGANIZATION_IDENTIFIER for the bundle identifier The ORGANIZATION_IDENTIFIER was not being used on the Mac and Safari Extension. This made the bundle and provisioning profile be com.ranchero.XYZ, which now conflicts because of added entitlements and signing. Changing this to use the ORGANIZATION_IDENTIFIER lets developers have a unique ID --- xcconfig/NetNewsWire_macapp_target.xcconfig | 2 +- xcconfig/NetNewsWire_safariextension_target.xcconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xcconfig/NetNewsWire_macapp_target.xcconfig b/xcconfig/NetNewsWire_macapp_target.xcconfig index f24b25dbf..fa302be5f 100644 --- a/xcconfig/NetNewsWire_macapp_target.xcconfig +++ b/xcconfig/NetNewsWire_macapp_target.xcconfig @@ -37,6 +37,6 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon CODE_SIGN_ENTITLEMENTS = Mac/Resources/NetNewsWire.entitlements INFOPLIST_FILE = Mac/Resources/Info.plist LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/../Frameworks -PRODUCT_BUNDLE_IDENTIFIER = com.ranchero.NetNewsWire-Evergreen +PRODUCT_BUNDLE_IDENTIFIER = $(ORGANIZATION_IDENTIFIER).NetNewsWire-Evergreen PRODUCT_NAME = NetNewsWire SWIFT_OBJC_BRIDGING_HEADER = Mac/NetNewsWire-Bridging-Header.h diff --git a/xcconfig/NetNewsWire_safariextension_target.xcconfig b/xcconfig/NetNewsWire_safariextension_target.xcconfig index d1cc16acd..d77bb41e7 100644 --- a/xcconfig/NetNewsWire_safariextension_target.xcconfig +++ b/xcconfig/NetNewsWire_safariextension_target.xcconfig @@ -34,7 +34,7 @@ PROVISIONING_PROFILE_SPECIFIER = CODE_SIGN_ENTITLEMENTS = Mac/SafariExtension/Subscribe_to_Feed.entitlements INFOPLIST_FILE = Mac/SafariExtension/Info.plist LD_RUNPATH_SEARCH_PATHS = $(inherited) @executable_path/../Frameworks @executable_path/../../../../Frameworks -PRODUCT_BUNDLE_IDENTIFIER = com.ranchero.NetNewsWire-Evergreen.Subscribe-to-Feed +PRODUCT_BUNDLE_IDENTIFIER = $(ORGANIZATION_IDENTIFIER).NetNewsWire-Evergreen.Subscribe-to-Feed PRODUCT_NAME = $(TARGET_NAME) SDKROOT = macosx