From 4e1f6d4cd808e83dd11b0b7571765d48c39d92b8 Mon Sep 17 00:00:00 2001
From: Stuart Breckenridge <stuart.breckenridge@icloud.com>
Date: Mon, 24 Jan 2022 21:47:55 +0800
Subject: [PATCH] slightly better translucent behaviour

Known issue: nav bar on article view is opaque.
---
 .../InteractiveNavigationController.swift     | 38 +++++++++++++------
 1 file changed, 26 insertions(+), 12 deletions(-)

diff --git a/iOS/UIKit Extensions/InteractiveNavigationController.swift b/iOS/UIKit Extensions/InteractiveNavigationController.swift
index 7054341ae..7ad5fb85b 100644
--- a/iOS/UIKit Extensions/InteractiveNavigationController.swift	
+++ b/iOS/UIKit Extensions/InteractiveNavigationController.swift	
@@ -46,29 +46,43 @@ private extension InteractiveNavigationController {
 	func configure() {
 		isToolbarHidden = false
 		
-		let scrollEdgeStandardAppearance = UINavigationBarAppearance()
-		
-		scrollEdgeStandardAppearance.shadowColor = nil
-		scrollEdgeStandardAppearance.titleTextAttributes = [
+		// Standard appearance with system background
+		let standardAppearance = UINavigationBarAppearance()
+		standardAppearance.backgroundColor = .clear
+		standardAppearance.shadowColor = nil
+		standardAppearance.titleTextAttributes = [
 			.foregroundColor: UIColor.label,
 			.font: UIFont.systemFont(ofSize: UIFont.preferredFont(forTextStyle: .body).pointSize, weight: .heavy)
 		]
-		scrollEdgeStandardAppearance.largeTitleTextAttributes = [
+		standardAppearance.largeTitleTextAttributes = [
 			.foregroundColor: UIColor.label,
 			.font: UIFont.systemFont(ofSize: UIFont.preferredFont(forTextStyle: .largeTitle).pointSize - 3, weight: .black)
 		]
-		navigationBar.tintColor = AppAssets.primaryAccentColor
-		navigationBar.standardAppearance = scrollEdgeStandardAppearance
-		navigationBar.isTranslucent = true
-		navigationBar.scrollEdgeAppearance = nil
-		navigationBar.compactAppearance = nil
-		navigationBar.compactScrollEdgeAppearance = nil
+		
+		let scrollEdgeAppearance = UINavigationBarAppearance()
+		scrollEdgeAppearance.backgroundColor = .systemBackground
+		scrollEdgeAppearance.shadowColor = nil
+		scrollEdgeAppearance.titleTextAttributes = [
+			.foregroundColor: UIColor.label,
+			.font: UIFont.systemFont(ofSize: UIFont.preferredFont(forTextStyle: .body).pointSize, weight: .heavy)
+		]
+		scrollEdgeAppearance.largeTitleTextAttributes = [
+			.foregroundColor: UIColor.label,
+			.font: UIFont.systemFont(ofSize: UIFont.preferredFont(forTextStyle: .largeTitle).pointSize - 3, weight: .black)
+		]
+		
+		
+		navigationBar.standardAppearance = standardAppearance
+		navigationBar.scrollEdgeAppearance = scrollEdgeAppearance
+		navigationBar.compactAppearance = standardAppearance
+		navigationBar.compactScrollEdgeAppearance = scrollEdgeAppearance
 		
 		
 		let toolbarAppearance = UIToolbarAppearance()
 		toolbarAppearance.shadowColor = nil
 		toolbar.standardAppearance = toolbarAppearance
-		toolbar.compactAppearance = toolbarAppearance
+		toolbar.compactAppearance = nil
+		toolbar.scrollEdgeAppearance = nil
 		toolbar.tintColor = AppAssets.primaryAccentColor
 	}