From 4e7ef7271ae70636da2fc52d93d4b53aa9e8b248 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Sat, 21 Sep 2019 12:43:15 -0500 Subject: [PATCH] Fix content offset bug in detail view --- iOS/Detail/DetailViewController.swift | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/iOS/Detail/DetailViewController.swift b/iOS/Detail/DetailViewController.swift index 23d1bcd0f..9878be601 100644 --- a/iOS/Detail/DetailViewController.swift +++ b/iOS/Detail/DetailViewController.swift @@ -48,11 +48,13 @@ class DetailViewController: UIViewController { DetailViewControllerWebViewProvider.shared.dequeueWebView() { webView in self.webView = webView + self.webViewContainer.addChildAndPin(webView) webView.navigationDelegate = self - self.webViewContainer.addChildAndPin(webView) - self.updateArticleSelection() - + // Even though page.html should be loaded into this webview, we have to do it again + // to work around this bug: http://www.openradar.me/22855188 + webView.loadHTMLString(ArticleRenderer.page.html, baseURL: ArticleRenderer.page.baseURL) + } } @@ -237,6 +239,11 @@ extension DetailViewController: WKNavigationDelegate { } } + + func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) { + self.updateArticleSelection() + } + } // MARK: Private