From accc4e7efe95d586d209acf87b3cd21b5c3a3c17 Mon Sep 17 00:00:00 2001 From: Rizwan Mohamed Ibrahim Date: Wed, 1 Jul 2020 13:02:20 +0530 Subject: [PATCH 1/5] Add Github and slack privacy polices to tech notes --- Technotes/privacypolicy.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Technotes/privacypolicy.markdown b/Technotes/privacypolicy.markdown index 8119b7e9a..a8575b02d 100644 --- a/Technotes/privacypolicy.markdown +++ b/Technotes/privacypolicy.markdown @@ -50,9 +50,9 @@ Neither ranchero.com nor inessential.com use any cookies or JavaScript, and they ### Related sites -The [NetNewsWire GitHub repository](https://github.com/brentsimmons/NetNewsWire) does use cookies and JavaScript, because that’s how GitHub works. The repository, including the issue tracker and anything you post there, is public. See [GitHub’s privacy policy](link_tbd) for more information. +The [NetNewsWire GitHub repository](https://github.com/brentsimmons/NetNewsWire) does use cookies and JavaScript, because that’s how GitHub works. The repository, including the issue tracker and anything you post there, is public. See [GitHub’s privacy policy](https://help.github.com/en/github/site-policy/github-privacy-statement) for more information. -The NetNewsWire Slack group also uses cookies and JavaScript, because that’s how Slack works. The group is public: anyone may join. See [Slack’s privacy policy](link_tbd) for more info. +The NetNewsWire Slack group also uses cookies and JavaScript, because that’s how Slack works. The group is public: anyone may join. See [Slack’s privacy policy](https://slack.com/privacy-policy) for more info. Posting to the GitHub repository and joining the Slack group are optional, opt-in activities. From dc57981376b1138196d1fd7fe88017553b7acdcd Mon Sep 17 00:00:00 2001 From: Nate Weaver Date: Thu, 2 Jul 2020 04:32:58 -0500 Subject: [PATCH 2/5] Only wrap iframes that don't specify their own height (master version of e183a5406c5b8216553fbf2b2ffd77e39309c6bd) --- Shared/Article Rendering/main.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Shared/Article Rendering/main.js b/Shared/Article Rendering/main.js index 9b9535bae..6c79007fd 100644 --- a/Shared/Article Rendering/main.js +++ b/Shared/Article Rendering/main.js @@ -1,6 +1,9 @@ // Here we are making iframes responsive. Particularly useful for inline Youtube videos. function wrapFrames() { document.querySelectorAll("iframe").forEach(element => { + if (element.height > 0 || parseInt(element.style.height) > 0) + return; + var wrapper = document.createElement("div"); wrapper.classList.add("iframeWrap"); element.parentNode.insertBefore(wrapper, element); From 014724e6a79bf2b7c19858240e9c527512ada8bd Mon Sep 17 00:00:00 2001 From: Nate Weaver Date: Thu, 2 Jul 2020 04:43:22 -0500 Subject: [PATCH 3/5] Don't force iframe height to auto Prevents truncating of YouTube embeds without needing a wrapper div. (master version of 82f8951c9647b245a956cc1f7a20a1742f60de31). This also sets max-width: 100%; on video instead of width: 100% !important;. --- Shared/Article Rendering/shared.css | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Shared/Article Rendering/shared.css b/Shared/Article Rendering/shared.css index 3dd1c9997..e487b3112 100644 --- a/Shared/Article Rendering/shared.css +++ b/Shared/Article Rendering/shared.css @@ -171,23 +171,22 @@ code, pre { padding: 0; } -img, figure, iframe, div { +img, figure, video, div { max-width: 100%; height: auto !important; margin: 0 auto; } +iframe { + max-width: 100%; + margin: 0 auto; +} + figure { margin-bottom: 1em; margin-top: 1em; } -video { - width: 100% !important; - height: auto !important; - margin: 0 auto; -} - figcaption { font-size: 14px; line-height: 1.3em; From 480dd803cfe1bdc31158350fda7edd6e0fd5ba45 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 6 Jul 2020 02:04:30 +0100 Subject: [PATCH 4/5] Update README to link CI badge to CI builds The image is hyperlinked by default in GitHub Flavoured Markdown, but points to the image itself, which is not so useful. Link it to the list of recent builds instead. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5ae52f7d8..ee59093f4 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # ![Icon](Technotes/Images/icon.png) NetNewsWire -![CI](https://github.com/Ranchero-Software/NetNewsWire/workflows/CI/badge.svg?branch=master) +[![CI](https://github.com/Ranchero-Software/NetNewsWire/workflows/CI/badge.svg?branch=master)](https://github.com/Ranchero-Software/NetNewsWire/actions?query=workflow%3ACI+branch%3Amaster) It’s a free and open source feed reader for macOS and iOS. From 4ba2ab4baaf7e2acd777f096f303c5e17559f501 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Wed, 8 Jul 2020 13:22:19 -0500 Subject: [PATCH 5/5] Complete the dequeue operation even if the web view navigation fails --- iOS/Article/WebViewProvider.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iOS/Article/WebViewProvider.swift b/iOS/Article/WebViewProvider.swift index 41c0e550c..2d820c181 100644 --- a/iOS/Article/WebViewProvider.swift +++ b/iOS/Article/WebViewProvider.swift @@ -116,8 +116,8 @@ class WebViewProviderDequeueOperation: MainThreadOperation { webView.ready { preloadedWebView in preloadedWebView.removeFromSuperview() self.completion(preloadedWebView) - self.operationDelegate?.operationDidComplete(self) } + self.operationDelegate?.operationDidComplete(self) return } @@ -127,8 +127,8 @@ class WebViewProviderDequeueOperation: MainThreadOperation { webView.preload() webView.ready { preloadedWebView in self.completion(preloadedWebView) - self.operationDelegate?.operationDidComplete(self) } + self.operationDelegate?.operationDidComplete(self) } }