From 336d7a8cc73281df7e450a8533a52a017407ce3e Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 19:42:06 -0500 Subject: [PATCH 1/8] Use default account name as placeholder text --- iOS/Settings/DetailAccountViewController.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/iOS/Settings/DetailAccountViewController.swift b/iOS/Settings/DetailAccountViewController.swift index 9ab945120..11deef01e 100644 --- a/iOS/Settings/DetailAccountViewController.swift +++ b/iOS/Settings/DetailAccountViewController.swift @@ -20,6 +20,8 @@ class DetailAccountViewController: UITableViewController { super.viewDidLoad() guard let account = account else { return } + + nameTextField.placeholder = account.defaultName nameTextField.text = account.name nameTextField.delegate = self activeSwitch.isOn = account.isActive From 490b84719a8cc40315948e536eb58fcc977518da Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 19:43:12 -0500 Subject: [PATCH 2/8] Cleaned up margins and added dynamic type support to account detail screen --- iOS/Settings/Settings.storyboard | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index 7a67ec398..7ab5984b2 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -347,9 +347,9 @@ - + - + @@ -360,9 +360,9 @@ - - + From fd88f94959930a688337bb4991b3e0f560504879 Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 20:00:18 -0500 Subject: [PATCH 3/8] Left align add account selection --- iOS/Settings/Settings.storyboard | 80 ++++++++++++++------------------ 1 file changed, 36 insertions(+), 44 deletions(-) diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index 7ab5984b2..714c3f4aa 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -437,30 +437,26 @@ - - - - - - - - - - - - - - + + + + + + + + + - - - + + + + @@ -472,30 +468,26 @@ - - - - - - - - - - - - - - + + + + + + + + + - - - + + + + From d1684a1c69064239da314a0460134dc0f9cb19f0 Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 20:29:00 -0500 Subject: [PATCH 4/8] Improved the UI of adding a new local account --- iOS/Settings/AddAccountViewController.swift | 6 +-- .../AddLocalAccountViewController.swift | 7 +-- iOS/Settings/Settings.storyboard | 47 +++++++++++-------- 3 files changed, 31 insertions(+), 29 deletions(-) diff --git a/iOS/Settings/AddAccountViewController.swift b/iOS/Settings/AddAccountViewController.swift index c4e7a6285..8261db2b5 100644 --- a/iOS/Settings/AddAccountViewController.swift +++ b/iOS/Settings/AddAccountViewController.swift @@ -29,19 +29,19 @@ class AddAccountViewController: UITableViewController, AddAccountDismissDelegate let navController = UIStoryboard.settings.instantiateViewController(withIdentifier: "AddLocalAccountNavigationViewController") as! UINavigationController let addViewController = navController.topViewController as! AddLocalAccountViewController addViewController.delegate = self - present(navController, animated: true) + navigationController?.pushViewController(addViewController, animated: true) case 1: let navController = UIStoryboard.settings.instantiateViewController(withIdentifier: "FeedbinAccountNavigationViewController") as! UINavigationController let addViewController = navController.topViewController as! FeedbinAccountViewController addViewController.delegate = self - present(navController, animated: true) + navigationController?.pushViewController(addViewController, animated: true) default: break } } func dismiss() { - navigationController?.popViewController(animated: false) + navigationController?.popToRootViewController(animated: true) } } diff --git a/iOS/Settings/AddLocalAccountViewController.swift b/iOS/Settings/AddLocalAccountViewController.swift index 6973a48d8..1ace24fb4 100644 --- a/iOS/Settings/AddLocalAccountViewController.swift +++ b/iOS/Settings/AddLocalAccountViewController.swift @@ -23,14 +23,9 @@ class AddLocalAccountViewController: UIViewController { nameTextField.delegate = self } - @IBAction func cancel(_ sender: Any) { - dismiss(animated: true) - } - - @IBAction func done(_ sender: Any) { + @IBAction func addAccountTapped(_ sender: Any) { let account = AccountManager.shared.createAccount(type: .onMyMac) account.name = nameTextField.text - dismiss(animated: true) delegate?.dismiss() } diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index 714c3f4aa..f5bbf677b 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -337,7 +337,7 @@ - + @@ -517,7 +517,7 @@ - + @@ -535,37 +535,44 @@ - - + + - + + - + - + + + + + + + - + - - - - - - - - - - - - + From 3e97754ab9d7fc1c6909051566b2379dc88909bf Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 20:31:01 -0500 Subject: [PATCH 5/8] Removed navigation controller from storyboard for add account view controller --- iOS/Settings/AddAccountViewController.swift | 3 +-- iOS/Settings/Settings.storyboard | 28 +++++---------------- 2 files changed, 7 insertions(+), 24 deletions(-) diff --git a/iOS/Settings/AddAccountViewController.swift b/iOS/Settings/AddAccountViewController.swift index 8261db2b5..e3bdf31b3 100644 --- a/iOS/Settings/AddAccountViewController.swift +++ b/iOS/Settings/AddAccountViewController.swift @@ -26,8 +26,7 @@ class AddAccountViewController: UITableViewController, AddAccountDismissDelegate override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { switch indexPath.row { case 0: - let navController = UIStoryboard.settings.instantiateViewController(withIdentifier: "AddLocalAccountNavigationViewController") as! UINavigationController - let addViewController = navController.topViewController as! AddLocalAccountViewController + let addViewController = UIStoryboard.settings.instantiateViewController(withIdentifier: "AddLocalAccountViewController") as! AddLocalAccountViewController addViewController.delegate = self navigationController?.pushViewController(addViewController, animated: true) case 1: diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index f5bbf677b..011da8f45 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -438,7 +438,7 @@ - + @@ -517,10 +517,10 @@ - + - + @@ -536,7 +536,7 @@ - + @@ -545,7 +545,7 @@ + - + - + + + + + + - + + + + - - - - - - - - - - - @@ -692,8 +686,7 @@ - - + @@ -701,7 +694,7 @@ - + From 071bfd6a4595c9d0ee6e14a4aef99b4f2b852a5c Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 21:19:13 -0500 Subject: [PATCH 7/8] Show disclosure indicator for add account cells --- iOS/Settings/Settings.storyboard | 36 +++++++++++++++----------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index 63ee963f4..e78663f9d 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -430,11 +430,11 @@ - + - + @@ -461,11 +461,11 @@ - + - + @@ -668,21 +668,19 @@ - - - - - - - - - - - - + + + + + + + + + + From cee87ab25ae0d2bcf0587131f479312deae53a97 Mon Sep 17 00:00:00 2001 From: Phil Viso Date: Wed, 22 May 2019 21:20:56 -0500 Subject: [PATCH 8/8] Centered email and password text --- iOS/Settings/Settings.storyboard | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index e78663f9d..3a39daaac 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -609,7 +609,7 @@ - + @@ -618,7 +618,7 @@ - +