From 77dc455ce9c3c8e0cdcf5ff309c821f37220c48e Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Sun, 19 Jul 2020 20:12:48 -0500 Subject: [PATCH] Disable Mark All as Read in Feed context menu item as it was just crushing Timeline performance --- .../Shared/Timeline/TimelineContextMenu.swift | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/Multiplatform/Shared/Timeline/TimelineContextMenu.swift b/Multiplatform/Shared/Timeline/TimelineContextMenu.swift index b32ae9309..0c2994b7c 100644 --- a/Multiplatform/Shared/Timeline/TimelineContextMenu.swift +++ b/Multiplatform/Shared/Timeline/TimelineContextMenu.swift @@ -81,17 +81,19 @@ struct TimelineContextMenu: View { } } - if let feed = timelineItem.article.webFeed, timelineModel.canMarkAllAsReadInFeed(feed) { - Divider() - Button { - timelineModel.markAllAsReadInFeed(feed) - } label: { - Text("Mark All as Read in “\(feed.nameForDisplay)”") - #if os(iOS) - AppAssets.markAllAsReadImage - #endif - } - } +// This thing isn't lazily initialized and gets called excessively even for things like selecting an article + +// if let feed = timelineItem.article.webFeed, timelineModel.canMarkAllAsReadInFeed(feed) { +// Divider() +// Button { +// timelineModel.markAllAsReadInFeed(feed) +// } label: { +// Text("Mark All as Read in “\(feed.nameForDisplay)”") +// #if os(iOS) +// AppAssets.markAllAsReadImage +// #endif +// } +// } if timelineModel.canOpenIndicatedArticleInBrowser(timelineItem.article) { Divider()