diff --git a/iOS/Settings/AddLocalAccountViewController.swift b/iOS/Settings/AddLocalAccountViewController.swift index c89569eaf..b9c092336 100644 --- a/iOS/Settings/AddLocalAccountViewController.swift +++ b/iOS/Settings/AddLocalAccountViewController.swift @@ -9,18 +9,15 @@ import UIKit import Account -class AddLocalAccountViewController: UIViewController { +class AddLocalAccountViewController: UITableViewController { - @IBOutlet weak var cancelBarButtonItem: UIBarButtonItem! - @IBOutlet private weak var localAccountNameLabel: UILabel! @IBOutlet weak var nameTextField: UITextField! weak var delegate: AddAccountDismissDelegate? override func viewDidLoad() { super.viewDidLoad() - - localAccountNameLabel.text = Account.defaultLocalAccountName + navigationItem.title = Account.defaultLocalAccountName nameTextField.delegate = self } @@ -29,7 +26,7 @@ class AddLocalAccountViewController: UIViewController { delegate?.dismiss() } - @IBAction func addAccountTapped(_ sender: Any) { + @IBAction func add(_ sender: Any) { let account = AccountManager.shared.createAccount(type: .onMyMac) account.name = nameTextField.text dismiss(animated: true, completion: nil) diff --git a/iOS/Settings/DetailAccountViewController.swift b/iOS/Settings/DetailAccountViewController.swift index 6f8c45636..9e516bda3 100644 --- a/iOS/Settings/DetailAccountViewController.swift +++ b/iOS/Settings/DetailAccountViewController.swift @@ -97,6 +97,7 @@ private extension DetailAccountViewController { let navController = UIStoryboard.settings.instantiateViewController(withIdentifier: "FeedbinAccountNavigationViewController") as! UINavigationController let addViewController = navController.topViewController as! FeedbinAccountViewController addViewController.account = account + navController.modalPresentationStyle = .currentContext present(navController, animated: true) default: break diff --git a/iOS/Settings/FeedbinAccountViewController.swift b/iOS/Settings/FeedbinAccountViewController.swift index e7218bfe1..89264bb1c 100644 --- a/iOS/Settings/FeedbinAccountViewController.swift +++ b/iOS/Settings/FeedbinAccountViewController.swift @@ -10,7 +10,7 @@ import UIKit import Account import RSWeb -class FeedbinAccountViewController: UIViewController { +class FeedbinAccountViewController: UITableViewController { @IBOutlet weak var activityIndicator: UIActivityIndicatorView! @IBOutlet weak var cancelBarButtonItem: UIBarButtonItem! @@ -19,8 +19,6 @@ class FeedbinAccountViewController: UIViewController { @IBOutlet weak var showHideButton: UIButton! @IBOutlet weak var actionButton: UIButton! - @IBOutlet weak var errorMessageLabel: UILabel! - weak var account: Account? weak var delegate: AddAccountDismissDelegate? @@ -56,10 +54,9 @@ class FeedbinAccountViewController: UIViewController { } @IBAction func action(_ sender: Any) { - self.errorMessageLabel.text = nil guard let email = emailTextField.text, let password = passwordTextField.text else { - self.errorMessageLabel.text = NSLocalizedString("Username & password required.", comment: "Credentials Error") + showError(NSLocalizedString("Username & password required.", comment: "Credentials Error")) return } @@ -104,18 +101,22 @@ class FeedbinAccountViewController: UIViewController { self.dismiss(animated: true, completion: nil) self.delegate?.dismiss() } catch { - self.errorMessageLabel.text = NSLocalizedString("Keychain error while storing credentials.", comment: "Credentials Error") + self.showError(NSLocalizedString("Keychain error while storing credentials.", comment: "Credentials Error")) } } else { - self.errorMessageLabel.text = NSLocalizedString("Invalid email/password combination.", comment: "Credentials Error") + self.showError(NSLocalizedString("Invalid email/password combination.", comment: "Credentials Error")) } case .failure: - self.errorMessageLabel.text = NSLocalizedString("Network error. Try again later.", comment: "Credentials Error") + self.showError(NSLocalizedString("Network error. Try again later.", comment: "Credentials Error")) } } } + private func showError(_ message: String) { + presentError(title: "Error", message: message) + } + private func enableNavigation() { self.cancelBarButtonItem.isEnabled = true self.actionButton.isEnabled = true diff --git a/iOS/Settings/Settings.storyboard b/iOS/Settings/Settings.storyboard index 5f53772e1..538fbcf4a 100644 --- a/iOS/Settings/Settings.storyboard +++ b/iOS/Settings/Settings.storyboard @@ -1,9 +1,8 @@ - + - @@ -422,7 +421,6 @@ @@ -495,8 +493,8 @@ - - + + @@ -529,7 +527,7 @@ - + @@ -575,7 +573,7 @@ - + @@ -591,197 +589,201 @@ - + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - + - - + + - + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - + + - @@ -790,18 +792,17 @@ - - - - - - - + + + + + + - - + + - +