From 7e651479cf6cd6084609fce6f0883a3abe283e0e Mon Sep 17 00:00:00 2001 From: Winnie Quinn Date: Wed, 20 Mar 2024 01:43:02 -0400 Subject: [PATCH] Fix account add crash As reported in #3606, it was the case that attempting to add an account could result in a crash. This fixes the problem by retaining the `NSHostingController` that holds the `AddAccountsView` view in a manner similar to how 48138b1 retained `accountsAddLocalWindowController`. --- .../Accounts/AccountsPreferencesViewController.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Mac/Preferences/Accounts/AccountsPreferencesViewController.swift b/Mac/Preferences/Accounts/AccountsPreferencesViewController.swift index b1aa87766..30d295600 100644 --- a/Mac/Preferences/Accounts/AccountsPreferencesViewController.swift +++ b/Mac/Preferences/Accounts/AccountsPreferencesViewController.swift @@ -24,6 +24,7 @@ final class AccountsPreferencesViewController: NSViewController { @IBOutlet weak var deleteButton: NSButton! var addAccountDelegate: AccountsPreferencesAddAccountDelegate? var addAccountWindowController: NSWindowController? + var addAccountsViewController: NSHostingController? private var sortedAccounts = [Account]() @@ -52,6 +53,7 @@ final class AccountsPreferencesViewController: NSViewController { let controller = NSHostingController(rootView: AddAccountsView(delegate: self)) controller.rootView.parent = controller presentAsSheet(controller) + addAccountsViewController = controller } @IBAction func removeAccount(_ sender: Any) {