From 96671df6674324d86ab8939748cd76e5dccbada1 Mon Sep 17 00:00:00 2001 From: Brian Sanders Date: Wed, 13 May 2020 06:13:31 -0400 Subject: [PATCH] Adds keyboard shortcut for "Find in Article" (iOS) --- iOS/Article/ArticleViewController.swift | 2 +- iOS/KeyboardManager.swift | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/iOS/Article/ArticleViewController.swift b/iOS/Article/ArticleViewController.swift index 5a054c350..30d5ac813 100644 --- a/iOS/Article/ArticleViewController.swift +++ b/iOS/Article/ArticleViewController.swift @@ -343,7 +343,7 @@ extension ArticleViewController { ]) } - @objc func beginFind(_ notification: Notification) { + @objc func beginFind(_ _: Any? = nil) { searchBar.isHidden = false navigationController?.setToolbarHidden(true, animated: true) currentWebViewController?.additionalSafeAreaInsets.bottom = searchBar.frame.height diff --git a/iOS/KeyboardManager.swift b/iOS/KeyboardManager.swift index a13f44ceb..36c7a0544 100644 --- a/iOS/KeyboardManager.swift +++ b/iOS/KeyboardManager.swift @@ -185,6 +185,9 @@ private extension KeyboardManager { let toggleStarredTitle = NSLocalizedString("Toggle Starred Status", comment: "Toggle Starred Status") keys.append(KeyboardManager.createKeyCommand(title: toggleStarredTitle, action: "toggleStarred:", input: "l", modifiers: [.command, .shift])) + + let findInArticleTitle = NSLocalizedString("Find in Article", comment: "Find in Article") + keys.append(KeyboardManager.createKeyCommand(title: findInArticleTitle, action: "beginFind:", input: "f", modifiers: [.command])) return keys }