From 9732ca10f3d1da9af2a82ff3e6409870fdf63170 Mon Sep 17 00:00:00 2001
From: Maurice Parker <mo@vincode.io>
Date: Sat, 18 Jul 2020 17:10:45 -0500
Subject: [PATCH] Made Sidebar Combine correct

---
 .../Shared/Sidebar/SidebarModel.swift         | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Multiplatform/Shared/Sidebar/SidebarModel.swift b/Multiplatform/Shared/Sidebar/SidebarModel.swift
index 2ca8d7987..bd63f87f9 100644
--- a/Multiplatform/Shared/Sidebar/SidebarModel.swift
+++ b/Multiplatform/Shared/Sidebar/SidebarModel.swift
@@ -86,19 +86,19 @@ private extension SidebarModel {
 	}
 	
 	func subscribeToSelectedFeedChanges() {
-		// TODO: This should be rewritten to use Combine correctly
-		$selectedFeedIdentifiers.sink { [weak self] feedIDs in
-			guard let self = self else { return }
-			self.selectedFeeds = feedIDs.compactMap { self.findFeed($0) }
-		}.store(in: &cancellables)
+		$selectedFeedIdentifiers.map { [weak self] feedIDs in
+			feedIDs.compactMap { self?.findFeed($0) }
+		}
+		.assign(to: $selectedFeeds)
 		
-		// TODO: This should be rewritten to use Combine correctly
-		$selectedFeedIdentifier.sink { [weak self] feedID in
-			guard let self = self else { return }
-			if let feedID = feedID, let feed = self.findFeed(feedID) {
-				self.selectedFeeds = [feed]
+		$selectedFeedIdentifier.map { [weak self] feedID in
+			if let feedID = feedID, let feed = self?.findFeed(feedID) {
+				return [feed]
+			} else {
+				return [Feed]()
 			}
-		}.store(in: &cancellables)
+		}
+		.assign(to: $selectedFeeds)
 	}
 	
 	func subscribeToReadFilterChanges() {