Fix favicon loading for sites with multiple/invalid favicons

Browse Source

Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser

...

This commit is contained in:

Nate Weaver

2019-11-25 19:54:09 -06:00

parent e2434e620c

commit 9de27febf0

4 changed files with 63 additions and 31 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2

submodules/RSParser

Submodule submodules/RSParser updated: f01129d762...81c400a766