From c6beb3c9dd7fd17b04c665c677a0a17b31870e35 Mon Sep 17 00:00:00 2001 From: Maurice Parker Date: Tue, 28 Jan 2020 15:39:02 -0700 Subject: [PATCH] Don't try to convert to an absolute img url when the img url is already absolute. Issue #1726 --- Shared/Article Rendering/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Shared/Article Rendering/main.js b/Shared/Article Rendering/main.js index c843c9a1c..ddfcf3e18 100644 --- a/Shared/Article Rendering/main.js +++ b/Shared/Article Rendering/main.js @@ -22,12 +22,12 @@ function stripStyles() { document.getElementsByTagName("body")[0].querySelectorAll("[style]").forEach(element => stripStylesFromElement(element, ["color", "background", "font"])); } -// Convert all Feedbin proxy images to be used as src, otherwise change image locations to be absolute +// Convert all Feedbin proxy images to be used as src, otherwise change image locations to be absolute if not already function convertImgSrc() { document.querySelectorAll("img").forEach(element => { if (element.hasAttribute("data-canonical-src")) { element.src = element.getAttribute("data-canonical-src") - } else { + } else if (!element.src.match(/^[a-z]+\:\/\//i)) { element.src = new URL(element.src, document.baseURI).href; } });