From d774e53647701501cbeb8b86584ff8bce665304d Mon Sep 17 00:00:00 2001
From: Stuart Breckenridge <stuart.breckenridge@icloud.com>
Date: Fri, 13 Jun 2025 14:31:15 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=92=A9=20Moves=20viewDidLoad=20function?=
 =?UTF-8?q?=20to=20viewWillAppear?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

These functions, when called from viewDidLoad, were resulting in memory errors:

error: Trying to put the stack in unreadable memory at: 0x16f0efc00.
---
 iOS/MainFeed/MainFeedViewController.swift | 24 +++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/iOS/MainFeed/MainFeedViewController.swift b/iOS/MainFeed/MainFeedViewController.swift
index 4fc8afb16..9cf824558 100644
--- a/iOS/MainFeed/MainFeedViewController.swift
+++ b/iOS/MainFeed/MainFeedViewController.swift
@@ -50,22 +50,17 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
 	override func viewDidLoad() {
 
 		super.viewDidLoad()
-
-		if traitCollection.userInterfaceIdiom == .phone {
-			navigationController?.navigationBar.prefersLargeTitles = true
-		}
 		
 		// If you don't have an empty table header, UIKit tries to help out by putting one in for you
 		// that makes a gap between the first section header and the navigation bar
-		var frame = CGRect.zero
-		frame.size.height = .leastNormalMagnitude
-		tableView.tableHeaderView = UIView(frame: frame)
+//		var frame = CGRect.zero
+//		frame.size.height = .leastNormalMagnitude
+//		tableView.tableHeaderView = UIView(frame: frame)
 		
 		tableView.register(MainFeedTableViewSectionHeader.self, forHeaderFooterViewReuseIdentifier: "SectionHeader")
 		tableView.dragDelegate = self
 		tableView.dropDelegate = self
 		tableView.dragInteractionEnabled = true
-		resetEstimatedRowHeight()
 		tableView.separatorStyle = .none
 
 		NotificationCenter.default.addObserver(self, selector: #selector(unreadCountDidChange(_:)), name: .UnreadCountDidChange, object: nil)
@@ -85,10 +80,7 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
 
 		registerForTraitChanges([UITraitPreferredContentSizeCategory.self], target: self, action: #selector(preferredContentSizeCategoryDidChange))
 
-		refreshControl = UIRefreshControl()
-		refreshControl!.addTarget(self, action: #selector(refreshAccounts(_:)), for: .valueChanged)
-
-		configureToolbar()
+		
 		becomeFirstResponder()
 	}
 
@@ -96,6 +88,14 @@ class MainFeedViewController: UITableViewController, UndoableCommandRunner {
 		navigationController?.isToolbarHidden = false		
 		updateUI()
 		super.viewWillAppear(animated)
+		
+		if traitCollection.userInterfaceIdiom == .phone {
+			navigationController?.navigationBar.prefersLargeTitles = true
+		}
+		resetEstimatedRowHeight()
+		refreshControl = UIRefreshControl()
+		refreshControl!.addTarget(self, action: #selector(refreshAccounts(_:)), for: .valueChanged)
+		configureToolbar()
 	}
 
 	// MARK: Notifications