renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add logging to HTMLMetadataDownloader. Make it not @MainActor, since it doesn’t need to be.

Browse Source
This commit is contained in:
Brent Simmons
2024-10-14 21:29:25 -07:00
parent ec1a579c6a
commit d7ac3f943c
1 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
Shared/HTMLMetadata/HTMLMetadataDownloader.swift
View File

@@ -7,12 +7,20 @@
//
import Foundation
import os
import Web
import Parser
struct HTMLMetadataDownloader {
@MainActor static func downloadMetadata(for url: String) async -> HTMLMetadata? {
nonisolated(unsafe) private static let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, category: "HTMLMetadataDownloader")
private static let debugLoggingEnabled = true
static func downloadMetadata(for url: String) async -> HTMLMetadata? {
if debugLoggingEnabled {
logger.debug("HTMLMetadataDownloader download for \(url)")
}
guard let actualURL = URL(string: url) else {
return nil
@@ -25,18 +33,23 @@ struct HTMLMetadataDownloader {
if let data, !data.isEmpty, let response, response.statusIsOK {
let urlToUse = response.url ?? actualURL
let parserData = ParserData(url: urlToUse.absoluteString, data: data)
if debugLoggingEnabled {
logger.debug("HTMLMetadataDownloader parsing metadata for \(url)")
}
return await parseMetadata(with: parserData)
}
if debugLoggingEnabled {
logger.debug("HTMLMetadataDownloader failed download for \(url)")
}
return nil
}
@MainActor private static func parseMetadata(with parserData: ParserData) async -> HTMLMetadata? {
private static func parseMetadata(with parserData: ParserData) async -> HTMLMetadata? {
let task = Task.detached { () -> HTMLMetadata? in
HTMLMetadataParser.metadata(with: parserData)
}
return await task.value
return HTMLMetadataParser.metadata(with: parserData)
}
}