renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Present SFSafariViewController using .overFullScreen instead of default .fullScreen — avoids a crash in -[UINavigationBar layoutSubviews]. Fix #4418.

Browse Source
This commit is contained in:
Brent Simmons
2024-12-05 22:06:00 -08:00
parent e3329e33f7
commit df8b404e1d
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
iOS/Article/WebViewController.swift
View File

@@ -273,8 +273,7 @@ class WebViewController: UIViewController {
if AppDefaults.shared.useSystemBrowser {
UIApplication.shared.open(url, options: [:])
} else {
let vc = SFSafariViewController(url: url)
present(vc, animated: true)
openURLInSafariViewController(url)
}
}
}
@@ -378,8 +377,7 @@ extension WebViewController: WKNavigationDelegate {
guard didOpen == false else {
return
}
let vc = SFSafariViewController(url: url)
self.present(vc, animated: true)
self.openURLInSafariViewController(url)
}
}
@@ -794,11 +792,16 @@ private extension WebViewController {
guard didOpen == false else {
return
}
let vc = SFSafariViewController(url: url)
self.present(vc, animated: true)
self.openURLInSafariViewController(url)
}
}
func openURLInSafariViewController(_ url: URL) {
let viewController = SFSafariViewController(url: url)
viewController.modalPresentationStyle = .overFullScreen // This avoids a crash with .fullScreen
present(viewController, animated: true)
}
}
// MARK: Find in Article

1
iOS/MasterFeed/MasterFeedViewController.swift
View File

@@ -676,6 +676,7 @@ class MasterFeedViewController: UITableViewController, UndoableCommandRunner {
if let indexPath = coordinator.currentFeedIndexPath,
let url = coordinator.homePageURLForFeed(indexPath) {
let vc = SFSafariViewController(url: url)
vc.modalPresentationStyle = .overFullScreen
present(vc, animated: true)
}
}