diff --git a/Mac/Base.lproj/Main.storyboard b/Mac/Base.lproj/Main.storyboard index 7f783c9f6..ddc504ef5 100644 --- a/Mac/Base.lproj/Main.storyboard +++ b/Mac/Base.lproj/Main.storyboard @@ -1,7 +1,7 @@ - + - + @@ -400,7 +400,7 @@ - + diff --git a/Mac/Base.lproj/UnifiedWindow.storyboard b/Mac/Base.lproj/UnifiedWindow.storyboard index 6c19a07e5..47a9cfde1 100644 --- a/Mac/Base.lproj/UnifiedWindow.storyboard +++ b/Mac/Base.lproj/UnifiedWindow.storyboard @@ -1,8 +1,7 @@ - + - - + diff --git a/Mac/MainWindow/MainWindowController.swift b/Mac/MainWindow/MainWindowController.swift index 768af1cf5..09bceefe2 100644 --- a/Mac/MainWindow/MainWindowController.swift +++ b/Mac/MainWindow/MainWindowController.swift @@ -273,20 +273,6 @@ final class MainWindowController : NSWindowController, NSUserInterfaceValidation return validateToggleReadArticles(item) } - if item.action == #selector(toggleTheSidebar(_:)) { - guard let splitViewItem = sidebarSplitViewItem else { - return false - } - - let sidebarIsShowing = !splitViewItem.isCollapsed - if let menuItem = item as? NSMenuItem { - let title = sidebarIsShowing ? NSLocalizedString("Hide Sidebar", comment: "Menu item") : NSLocalizedString("Show Sidebar", comment: "Menu item") - menuItem.title = title - } - - return true - } - return true } @@ -463,16 +449,6 @@ final class MainWindowController : NSWindowController, NSUserInterfaceValidation nextUnread(sender) } - @IBAction func toggleTheSidebar(_ sender: Any?) { - splitViewController!.toggleSidebar(sender) - guard let splitViewItem = sidebarSplitViewItem else { return } - if splitViewItem.isCollapsed { - currentTimelineViewController?.focus() - } else { - sidebarViewController?.focus() - } - } - @IBAction func markOlderArticlesAsRead(_ sender: Any?) { currentTimelineViewController?.markOlderArticlesRead() } @@ -769,7 +745,6 @@ extension MainWindowController : ScriptingMainWindowController { // MARK: - NSToolbarDelegate extension NSToolbarItem.Identifier { - static let sidebarToggle = NSToolbarItem.Identifier("sidebarToggle") static let newFeed = NSToolbarItem.Identifier("newFeed") static let newFolder = NSToolbarItem.Identifier("newFolder") static let refresh = NSToolbarItem.Identifier("refresh") @@ -794,10 +769,6 @@ extension MainWindowController: NSToolbarDelegate { switch itemIdentifier { - case .sidebarToggle: - let title = NSLocalizedString("Toggle Sidebar", comment: "Toggle Sidebar") - return buildToolbarButton(.toggleSidebar, title, AppAsset.toolbarSidebarToggleImage, "toggleTheSidebar:") - case .refresh: let title = NSLocalizedString("Refresh", comment: "Refresh") return buildToolbarButton(.refresh, title, AppAsset.toolbarRefreshImage, "refreshAll:") @@ -880,7 +851,7 @@ extension MainWindowController: NSToolbarDelegate { func toolbarAllowedItemIdentifiers(_ toolbar: NSToolbar) -> [NSToolbarItem.Identifier] { [ - .sidebarToggle, + NSToolbarItem.Identifier.toggleSidebar, .refresh, .newSidebarItemMenu, .sidebarTrackingSeparator, @@ -906,6 +877,7 @@ extension MainWindowController: NSToolbarDelegate { .refresh, .newSidebarItemMenu, .sidebarTrackingSeparator, + NSToolbarItem.Identifier.toggleSidebar, .markAllAsRead, .toggleReadArticlesFilter, .timelineTrackingSeparator, diff --git a/Shared/AppAsset.swift b/Shared/AppAsset.swift index ef169c46e..f6b108235 100644 --- a/Shared/AppAsset.swift +++ b/Shared/AppAsset.swift @@ -129,7 +129,6 @@ extension AppAsset { // MARK: - Mac Toolbar static let toolbarAddNewSidebarItemImage = RSImage.systemImage("plus") - static let toolbarSidebarToggleImage = RSImage.systemImage("sidebar.left") static let toolbarRefreshImage = RSImage.systemImage("arrow.clockwise") static let toolbarArticleThemeImage = RSImage.systemImage("doc.richtext") static let toolbarCleanUpImage = RSImage.systemImage("wind")