renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace uses of forEach with for-in loops.

Browse Source
This commit is contained in:
Brent Simmons
2023-07-09 22:29:37 -07:00
parent d3d718c1b0
commit e1d2560fc0
4 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Account/Sources/Account/FeedMetadataFile.swift
View File

@@ -35,7 +35,9 @@ import RSCore
let decoder = PropertyListDecoder() let decoder = PropertyListDecoder()
account.feedMetadata = (try? decoder.decode(Account.FeedMetadataDictionary.self, from: fileData)) ?? Account.FeedMetadataDictionary() account.feedMetadata = (try? decoder.decode(Account.FeedMetadataDictionary.self, from: fileData)) ?? Account.FeedMetadataDictionary()
} }
account.feedMetadata.values.forEach { $0.delegate = account } for value in account.feedMetadata.values {
value.delegate = account
}
} }
func save() { func save() {

6
Mac/MainWindow/Sidebar/SidebarViewController.swift
View File

@@ -540,7 +540,9 @@ private extension SidebarViewController {
} }
func addAllSelectedToFilterExceptions() { func addAllSelectedToFilterExceptions() {
selectedFeeds.forEach { addToFilterExeptionsIfNecessary($0) } for feed in selectedFeeds {
addToFilterExeptionsIfNecessary(feed)
}
} }
func addToFilterExeptionsIfNecessary(_ feedProtocol: FeedProtocol?) { func addToFilterExeptionsIfNecessary(_ feedProtocol: FeedProtocol?) {
@@ -583,7 +585,7 @@ private extension SidebarViewController {
restoreSelection(to: savedSelection, sendNotificationIfChanged: true) restoreSelection(to: savedSelection, sendNotificationIfChanged: true)
// Automatically expand any new or newly active accounts // Automatically expand any new or newly active accounts
AccountManager.shared.activeAccounts.forEach { account in for account in AccountManager.shared.activeAccounts {
if !savedAccounts.contains(account) { if !savedAccounts.contains(account) {
let accountNode = treeController.nodeInTreeRepresentingObject(account) let accountNode = treeController.nodeInTreeRepresentingObject(account)
outlineView.expandItem(accountNode) outlineView.expandItem(accountNode)

6
Shared/ShareExtension/ExtensionFeedAddRequestFile.swift
View File

@@ -127,7 +127,11 @@ private extension ExtensionFeedAddRequestFile {
logger.error("Save to disk coordination failed: \(error.localizedDescription, privacy: .public)") logger.error("Save to disk coordination failed: \(error.localizedDescription, privacy: .public)")
} }
requests?.forEach { processRequest($0) } if let requests {
for request in requests {
processRequest(request)
}
}
} }
@MainActor func processRequest(_ request: ExtensionFeedAddRequest) { @MainActor func processRequest(_ request: ExtensionFeedAddRequest) {

2
Shared/SmartFeeds/SmartFeed.swift
View File

@@ -66,7 +66,7 @@ final class SmartFeed: PseudoFeed {
// Remove any accounts that are no longer active or have been deleted // Remove any accounts that are no longer active or have been deleted
let activeAccountIDs = activeAccounts.map { $0.accountID } let activeAccountIDs = activeAccounts.map { $0.accountID }
unreadCounts.keys.forEach { accountID in for accountID in unreadCounts.keys {
if !activeAccountIDs.contains(accountID) { if !activeAccountIDs.contains(accountID) {
unreadCounts.removeValue(forKey: accountID) unreadCounts.removeValue(forKey: accountID)
} }