renun/NetNewsWire
1
0
Fork 0
mirror of https://github.com/Ranchero-Software/NetNewsWire synced 2025-08-12 06:26:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix two typos in JSONFeedParser which kept the parser from getting the feed’s favicon and icon URLs. Also added a test for this.

Browse Source
This commit is contained in:
Brent Simmons
2017-11-25 10:34:48 -08:00
parent 226a7d05b6
commit e4008b677f
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Frameworks/RSParser/Feeds/JSON/JSONFeedParser.swift
View File

@@ -34,8 +34,8 @@ public struct JSONFeedParser {
let feedURL = parsedObject["feed_url"] as? String ?? parserData.url
let feedDescription = parsedObject["description"] as? String
let nextURL = parsedObject["next_url"] as? String
let iconURL = parsedObject["icon_url"] as? String
let faviconURL = parsedObject["favicon_url"] as? String
let iconURL = parsedObject["icon"] as? String
let faviconURL = parsedObject["favicon"] as? String
let expired = parsedObject["expired"] as? Bool ?? false
let hubs = parseHubs(parsedObject)
@@ -149,9 +149,7 @@ private extension JSONFeedParser {
guard let attachmentsArray = itemDictionary["attachments"] as? JSONArray else {
return nil
}
return Set(attachmentsArray.flatMap { (oneAttachmentObject) -> ParsedAttachment? in
return parseAttachment(oneAttachmentObject)
})
return Set(attachmentsArray.flatMap { parseAttachment($0) })
}
static func parseAttachment(_ attachmentObject: JSONDictionary) -> ParsedAttachment? {