From e4c84bc5016b62209a225da8cff5d24d89a7ef8a Mon Sep 17 00:00:00 2001 From: Tim Ekl Date: Tue, 31 Dec 2019 19:41:32 -0600 Subject: [PATCH] Add two missing expectation fulfillments It looks like two tests in FeedlySetStarredArticlesOperationTests created but never referenced XCTestExpectation instances. Based on the other nearby tests, add a call to `fulfill()` inside the associated completion block after the rest of our test assertions are done. --- .../Feedly/FeedlySetStarredArticlesOperationTests.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Frameworks/Account/AccountTests/Feedly/FeedlySetStarredArticlesOperationTests.swift b/Frameworks/Account/AccountTests/Feedly/FeedlySetStarredArticlesOperationTests.swift index 28e376cda..59a58a2a4 100644 --- a/Frameworks/Account/AccountTests/Feedly/FeedlySetStarredArticlesOperationTests.swift +++ b/Frameworks/Account/AccountTests/Feedly/FeedlySetStarredArticlesOperationTests.swift @@ -257,6 +257,7 @@ class FeedlySetStarredArticlesOperationTests: XCTestCase { .map { $0.articleID }) XCTAssertEqual(idsOfStarredArticles, remainingStarredIds) + fetchIdsExpectation.fulfill() } catch let e { XCTFail("Error checking articles IDs: \(e)") } @@ -315,6 +316,7 @@ class FeedlySetStarredArticlesOperationTests: XCTestCase { .map { $0.articleID }) XCTAssertEqual(idsOfStarredArticles, remainingStarredIds) + fetchIdsExpectation.fulfill() } catch let e { XCTFail("Error checking articles IDs: \(e)") }