From eb7860eeb9e0f51a981eb9ae77ad333bc90a71b8 Mon Sep 17 00:00:00 2001 From: Stuart Breckenridge Date: Sun, 23 May 2021 18:24:27 +0800 Subject: [PATCH 01/13] Adds new Tweetbot share extension identifier. Fixes #3123 on iOS. --- iOS/TitleActivityItemSource.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/iOS/TitleActivityItemSource.swift b/iOS/TitleActivityItemSource.swift index 428b75f04..fff0609aa 100644 --- a/iOS/TitleActivityItemSource.swift +++ b/iOS/TitleActivityItemSource.swift @@ -30,6 +30,7 @@ class TitleActivityItemSource: NSObject, UIActivityItemSource { case "com.omnigroup.OmniFocus3.iOS.QuickEntry", "com.culturedcode.ThingsiPhone.ShareExtension", "com.tapbots.Tweetbot4.shareextension", + "com.tapbots.Tweetbot6.shareextension", "com.buffer.buffer.Buffer": return title default: From 9ab8a5061398cc8999c8c24d84ce667569166748 Mon Sep 17 00:00:00 2001 From: Stuart Breckenridge Date: Sun, 23 May 2021 18:40:12 +0800 Subject: [PATCH 02/13] iOS multiplatform updated --- Multiplatform/iOS/Article/TitleActivityItemSource.swift | 1 + 1 file changed, 1 insertion(+) diff --git a/Multiplatform/iOS/Article/TitleActivityItemSource.swift b/Multiplatform/iOS/Article/TitleActivityItemSource.swift index 2c90d2dc4..6eaf1f520 100644 --- a/Multiplatform/iOS/Article/TitleActivityItemSource.swift +++ b/Multiplatform/iOS/Article/TitleActivityItemSource.swift @@ -30,6 +30,7 @@ class TitleActivityItemSource: NSObject, UIActivityItemSource { case "com.omnigroup.OmniFocus3.iOS.QuickEntry", "com.culturedcode.ThingsiPhone.ShareExtension", "com.tapbots.Tweetbot4.shareextension", + "com.tapbots.Tweetbot6.shareextension", "com.buffer.buffer.Buffer": return title default: From 04ba650bc8b0235646a3c835bff9a47467bc813d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kiel=20Gillard=20=F0=9F=A4=AA?= Date: Mon, 31 May 2021 09:12:39 +1000 Subject: [PATCH 03/13] Preserve custom feed names with Feedly when moving them between folders. Fixes #3109 --- .../Account/Feedly/FeedlyAccountDelegate.swift | 15 ++++++++------- .../FeedlyAddExistingFeedOperation.swift | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/Account/Sources/Account/Feedly/FeedlyAccountDelegate.swift b/Account/Sources/Account/Feedly/FeedlyAccountDelegate.swift index 0f9de2e5b..3108082fc 100644 --- a/Account/Sources/Account/Feedly/FeedlyAccountDelegate.swift +++ b/Account/Sources/Account/Feedly/FeedlyAccountDelegate.swift @@ -382,13 +382,14 @@ final class FeedlyAccountDelegate: AccountDelegate { } let resource = FeedlyFeedResourceId(id: feed.webFeedID) - let addExistingFeed = try FeedlyAddExistingFeedOperation(account: account, - credentials: credentials, - resource: resource, - service: caller, - container: container, - progress: refreshProgress, - log: log) + let addExistingFeed = try FeedlyAddExistingFeedOperation(account: account, + credentials: credentials, + resource: resource, + service: caller, + container: container, + progress: refreshProgress, + log: log, + customFeedName: feed.editedName) addExistingFeed.addCompletionHandler = { result in diff --git a/Account/Sources/Account/Feedly/Operations/FeedlyAddExistingFeedOperation.swift b/Account/Sources/Account/Feedly/Operations/FeedlyAddExistingFeedOperation.swift index 07dc4c8ca..ed0824663 100644 --- a/Account/Sources/Account/Feedly/Operations/FeedlyAddExistingFeedOperation.swift +++ b/Account/Sources/Account/Feedly/Operations/FeedlyAddExistingFeedOperation.swift @@ -17,7 +17,7 @@ class FeedlyAddExistingFeedOperation: FeedlyOperation, FeedlyOperationDelegate, private let operationQueue = MainThreadOperationQueue() var addCompletionHandler: ((Result) -> ())? - init(account: Account, credentials: Credentials, resource: FeedlyFeedResourceId, service: FeedlyAddFeedToCollectionService, container: Container, progress: DownloadProgress, log: OSLog) throws { + init(account: Account, credentials: Credentials, resource: FeedlyFeedResourceId, service: FeedlyAddFeedToCollectionService, container: Container, progress: DownloadProgress, log: OSLog, customFeedName: String? = nil) throws { let validator = FeedlyFeedContainerValidator(container: container) let (folder, collectionId) = try validator.getValidContainer() @@ -28,7 +28,7 @@ class FeedlyAddExistingFeedOperation: FeedlyOperation, FeedlyOperationDelegate, self.downloadProgress = progress - let addRequest = FeedlyAddFeedToCollectionOperation(account: account, folder: folder, feedResource: resource, feedName: nil, collectionId: collectionId, service: service) + let addRequest = FeedlyAddFeedToCollectionOperation(account: account, folder: folder, feedResource: resource, feedName: customFeedName, collectionId: collectionId, service: service) addRequest.delegate = self addRequest.downloadProgress = progress self.operationQueue.add(addRequest) From ae63d0feb7cf016bb6374d643ba042ebc17456e5 Mon Sep 17 00:00:00 2001 From: Brent Simmons Date: Mon, 31 May 2021 15:52:56 -0700 Subject: [PATCH 04/13] =?UTF-8?q?Add=20a=20warning=20about=20iCloud=20sync?= =?UTF-8?q?=20being=20slow=20sometimes.=20Also:=20in=20user-facing=20text,?= =?UTF-8?q?=20change=20=E2=80=9Csubscriptions=E2=80=9D=20to=20=E2=80=9Cfee?= =?UTF-8?q?ds.=E2=80=9D=20We=20want=20to=20use=20the=20word=20=E2=80=9Cfee?= =?UTF-8?q?d=E2=80=9D=20=E2=80=94=20a=20=E2=80=9Csubscription=E2=80=9D=20m?= =?UTF-8?q?akes=20people=20think=20of=20IAP.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Accounts/AccountsAddCloudKit.xib | 20 +++---- .../Accounts/AddAccountsView.swift | 8 +-- .../AddFeedWranglerAccountView.swift | 2 +- .../AddFeedbinAccountView.swift | 2 +- .../AddFeedlyAccountView.swift | 2 +- .../AddLocalAccountView.swift | 2 +- .../AddNewsBlurAccountView.swift | 2 +- .../AddReaderAPIAccountView.swift | 2 +- .../Add Account/AddAccountView.swift | 8 +-- iOS/Account/Account.storyboard | 54 +++++++++---------- .../CloudKitAccountViewController.swift | 2 +- .../FeedWranglerAccountViewController.swift | 2 +- .../FeedbinAccountViewController.swift | 2 +- iOS/Account/LocalAccountViewController.swift | 2 +- .../NewsBlurAccountViewController.swift | 2 +- .../ReaderAPIAccountViewController.swift | 8 +-- iOS/Settings/AddAccountViewController.swift | 8 +-- 17 files changed, 64 insertions(+), 64 deletions(-) diff --git a/Mac/Preferences/Accounts/AccountsAddCloudKit.xib b/Mac/Preferences/Accounts/AccountsAddCloudKit.xib index 0e286f444..e8a4a1b5d 100644 --- a/Mac/Preferences/Accounts/AccountsAddCloudKit.xib +++ b/Mac/Preferences/Accounts/AccountsAddCloudKit.xib @@ -18,16 +18,16 @@ - + - + - + @@ -48,26 +48,26 @@ DQ - + - + - + - - + + - + - + - + - + diff --git a/Mac/Preferences/Accounts/AccountsFeedbin.xib b/Mac/Preferences/Accounts/AccountsFeedbin.xib index 4feda6662..3f748de28 100644 --- a/Mac/Preferences/Accounts/AccountsFeedbin.xib +++ b/Mac/Preferences/Accounts/AccountsFeedbin.xib @@ -26,7 +26,7 @@ - + @@ -35,7 +35,7 @@ - + @@ -97,7 +97,7 @@ - + - + diff --git a/Mac/Preferences/Accounts/AccountsNewsBlur.xib b/Mac/Preferences/Accounts/AccountsNewsBlur.xib index c098cffc3..63e11c430 100644 --- a/Mac/Preferences/Accounts/AccountsNewsBlur.xib +++ b/Mac/Preferences/Accounts/AccountsNewsBlur.xib @@ -26,7 +26,7 @@ - + @@ -35,7 +35,7 @@ - + @@ -97,7 +97,7 @@