From f5f306f60f0175e6d63904410047706c398c4470 Mon Sep 17 00:00:00 2001 From: Brent Simmons Date: Sun, 8 Sep 2019 21:17:57 -0700 Subject: [PATCH] Add comments to feed.iconURL and feed.faviconURL, explaining that these are set only if that info was part of the feed (which is a JSON-Feed-only feature). --- Frameworks/Account/Feed.swift | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Frameworks/Account/Feed.swift b/Frameworks/Account/Feed.swift index f18c2c6dd..058bafdfc 100644 --- a/Frameworks/Account/Feed.swift +++ b/Frameworks/Account/Feed.swift @@ -39,6 +39,10 @@ public final class Feed: DisplayNameProvider, Renamable, UnreadCountProvider, Ha } } + // Note: this is available only if the icon URL was available in the feed. + // The icon URL is a JSON-Feed-only feature. + // Otherwise we find an icon URL via other means, but we don’t store it + // as part of feed metadata. public var iconURL: String? { get { return metadata.iconURL @@ -48,6 +52,10 @@ public final class Feed: DisplayNameProvider, Renamable, UnreadCountProvider, Ha } } + // Note: this is available only if the favicon URL was available in the feed. + // The favicon URL is a JSON-Feed-only feature. + // Otherwise we find a favicon URL via other means, but we don’t store it + // as part of feed metadata. public var faviconURL: String? { get { return metadata.faviconURL