diff --git a/Mac/MainWindow/MainWindowController.swift b/Mac/MainWindow/MainWindowController.swift index 71eecb393..87c3bd6fc 100644 --- a/Mac/MainWindow/MainWindowController.swift +++ b/Mac/MainWindow/MainWindowController.swift @@ -318,7 +318,7 @@ class MainWindowController : NSWindowController, NSUserInterfaceValidations { } @IBAction func copyExternalURL(_ sender: Any?) { - if let link = oneSelectedArticle?.rawExternalLink { + if let link = oneSelectedArticle?.externalLink { URLPasteboardWriter.write(urlString: link, to: .general) } } @@ -1077,7 +1077,7 @@ private extension MainWindowController { } func canCopyExternalURL() -> Bool { - return oneSelectedArticle?.rawExternalLink != nil && oneSelectedArticle?.rawExternalLink != currentLink + return oneSelectedArticle?.externalLink != nil && oneSelectedArticle?.externalLink != currentLink } func canGoToNextUnread(wrappingToTop wrapping: Bool = false) -> Bool { diff --git a/Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift b/Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift index cc43cfde2..cedfdea52 100644 --- a/Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift +++ b/Mac/MainWindow/Timeline/ArticlePasteboardWriter.swift @@ -87,11 +87,11 @@ private extension ArticlePasteboardWriter { s += "\(convertedHTML)\n\n" } - if let rawLink = article.rawLink { + if let link = article.link { s += "URL: \(rawLink)\n\n" } - if let rawExternalLink = article.rawExternalLink { - s += "external URL: \(rawExternalLink)\n\n" + if let externalLink = article.externalLink { + s += "external URL: \(externalLink)\n\n" } s += "Date: \(article.logicalDatePublished)\n\n" diff --git a/Mac/MainWindow/Timeline/TimelineViewController+ContextualMenus.swift b/Mac/MainWindow/Timeline/TimelineViewController+ContextualMenus.swift index 0d0758ed5..dd83afdcb 100644 --- a/Mac/MainWindow/Timeline/TimelineViewController+ContextualMenus.swift +++ b/Mac/MainWindow/Timeline/TimelineViewController+ContextualMenus.swift @@ -178,7 +178,7 @@ private extension TimelineViewController { menu.addSeparatorIfNeeded() menu.addItem(copyArticleURLMenuItem(link)) - if let externalLink = articles.first?.rawExternalLink, externalLink != link { + if let externalLink = articles.first?.externalLink, externalLink != link { menu.addItem(copyExternalURLMenuItem(externalLink)) } } diff --git a/Mac/Scriptability/Article+Scriptability.swift b/Mac/Scriptability/Article+Scriptability.swift index 070f252ca..6189d35c1 100644 --- a/Mac/Scriptability/Article+Scriptability.swift +++ b/Mac/Scriptability/Article+Scriptability.swift @@ -57,17 +57,17 @@ class ScriptableArticle: NSObject, UniqueIdScriptingObject, ScriptingObjectConta @objc(url) var url:String? { - return article.rawLink ?? article.rawExternalLink + return article.preferredLink } @objc(permalink) var permalink:String? { - return article.rawLink + return article.link } @objc(externalUrl) var externalUrl:String? { - return article.rawExternalLink + return article.externalLink } @objc(title) @@ -132,7 +132,7 @@ class ScriptableArticle: NSObject, UniqueIdScriptingObject, ScriptingObjectConta @objc(imageURL) var imageURL:String { - return article.rawImageLink ?? "" + return article.imageLink ?? "" } @objc(authors) diff --git a/Shared/Article Rendering/ArticleRenderer.swift b/Shared/Article Rendering/ArticleRenderer.swift index cf18d60e6..9ecd6a7b7 100644 --- a/Shared/Article Rendering/ArticleRenderer.swift +++ b/Shared/Article Rendering/ArticleRenderer.swift @@ -209,7 +209,7 @@ private extension ArticleRenderer { d["title"] = title d["preferred_link"] = article.preferredLink ?? "" - if let externalLink = article.rawExternalLink, externalLink != article.preferredLink { + if let externalLink = article.externalLink, externalLink != article.preferredLink { d["external_link_label"] = NSLocalizedString("Link:", comment: "Link") d["external_link_stripped"] = externalLink.strippingHTTPOrHTTPSScheme d["external_link"] = externalLink @@ -331,7 +331,7 @@ private extension ArticleRenderer { private extension Article { var baseURL: URL? { - var s = rawLink + var s = link if s == nil { s = webFeed?.homePageURL } diff --git a/Shared/ExtensionPoints/SendToMarsEditCommand.swift b/Shared/ExtensionPoints/SendToMarsEditCommand.swift index 2d2de88d2..c921d71c3 100644 --- a/Shared/ExtensionPoints/SendToMarsEditCommand.swift +++ b/Shared/ExtensionPoints/SendToMarsEditCommand.swift @@ -75,7 +75,7 @@ private extension SendToMarsEditCommand { let body = article.contentHTML ?? article.contentText ?? article.summary let authorName = article.authors?.first?.name - let sender = SendToBlogEditorApp(targetDescriptor: targetDescriptor, title: article.title, body: body, summary: article.summary, link: article.rawExternalLink, permalink: article.rawLink, subject: nil, creator: authorName, commentsURL: nil, guid: article.uniqueID, sourceName: article.webFeed?.nameForDisplay, sourceHomeURL: article.webFeed?.homePageURL, sourceFeedURL: article.webFeed?.url) + let sender = SendToBlogEditorApp(targetDescriptor: targetDescriptor, title: article.title, body: body, summary: article.summary, link: article.externalLink, permalink: article.link, subject: nil, creator: authorName, commentsURL: nil, guid: article.uniqueID, sourceName: article.webFeed?.nameForDisplay, sourceHomeURL: article.webFeed?.homePageURL, sourceFeedURL: article.webFeed?.url) let _ = sender.send() } diff --git a/iOS/MasterTimeline/MasterTimelineViewController.swift b/iOS/MasterTimeline/MasterTimelineViewController.swift index 2f1f9d051..0f16bd30a 100644 --- a/iOS/MasterTimeline/MasterTimelineViewController.swift +++ b/iOS/MasterTimeline/MasterTimelineViewController.swift @@ -739,7 +739,7 @@ private extension MasterTimelineViewController { } func featuredImageFor(_ article: Article) -> UIImage? { - if let url = article.rawImageLink, let data = appDelegate.imageDownloader.image(for: url) { + if let link = article.imageLink, let data = appDelegate.imageDownloader.image(for: link) { return RSImage(data: data) } return nil @@ -924,7 +924,7 @@ private extension MasterTimelineViewController { } func copyExternalURLAction(_ article: Article) -> UIAction? { - guard let externalLink = article.rawExternalLink, externalLink != article.preferredLink, let url = URL(string: externalLink) else { return nil } + guard let externalLink = article.externalLink, externalLink != article.preferredLink, let url = URL(string: externalLink) else { return nil } let title = NSLocalizedString("Copy External URL", comment: "Copy External URL") let action = UIAction(title: title, image: AppAssets.copyImage) { action in UIPasteboard.general.url = url