Commit Graph

58 Commits

Author SHA1 Message Date
Brent Simmons 8db1c7d447 Fix lint issues. 2025-02-01 19:44:19 -08:00
Brent Simmons 6e82063aa9 Fix build error. 2025-01-30 21:27:01 -08:00
Brent Simmons f91d673b5d Make FaviconDownloader.shared. 2025-01-30 21:07:46 -08:00
Brent Simmons 6ed742c5a7 Continuing migrating to AppImage. 2025-01-27 22:21:01 -08:00
Brent Simmons 5651764907 Mark classes as final that can be marked as final. 2025-01-25 11:01:12 -08:00
Brent Simmons ae2b017ae0 Fix lint issues. 2025-01-23 22:17:28 -08:00
Brent Simmons ec88ebee22 Fix lint issues. 2025-01-23 21:52:57 -08:00
Brent Simmons 1c2467e14a Fix lint issues. 2025-01-23 21:49:14 -08:00
Brent Simmons 10f4351904 Fix lint issues. 2025-01-22 22:20:08 -08:00
Brent Simmons 674dbb5bc3 Add debug Logger to FaviconDownloader. 2025-01-22 21:31:44 -08:00
Brent Simmons bdd858f509 Centralize logic for when to use the nnw feed icon. 2025-01-19 21:15:26 -08:00
Brent Simmons 703ecfa746 Fetch favicon (if needed) when HTMLMetadata is available. 2025-01-19 18:04:46 -08:00
Brent Simmons 59af6041ca Get Mac and iOS builds building. 2025-01-03 22:58:25 -08:00
Brent Simmons 90088735b1 Bring in changes from release branches. 2025-01-03 21:30:22 -08:00
Dimitris Apostolou ccd76a5354 Fix typos 2024-12-06 18:06:27 +02:00
Brent Simmons 85d1a8fe7a Switch to new Parser. 2024-11-15 22:59:51 -08:00
Brent Simmons 05347129bf Delete no-longer-needed (due to OS changes) UTS46 URL handling. 2024-11-09 10:23:13 -08:00
Brent Simmons 813500b55a Fix deprecation warnings related to UTIs. 2024-11-03 21:31:40 -08:00
Brent Simmons 4fa4c6a541 Continue renaming webFeed to feed. 2024-11-02 11:08:58 -07:00
Brent Simmons 050c47c41d Rename Feed protocol to SidebarItem. Rename FeedIdentifier to SidebarItemIdentifier. Rename WebFeed to Feed. 2024-11-01 21:34:08 -07:00
Brent Simmons 1020816e5b Update blog host name. 2023-06-13 21:48:11 -07:00
Nate Weaver 8911627a67 Fix favicons when a feed's homepage URL has non-ASCII in its path 2021-07-18 17:02:49 -05:00
Maurice Parker ef18600acc Separate background suppression from symbol processing. Fixes #2646 & Fixes #2635 2020-12-06 14:25:22 -06:00
Maurice Parker 67c0e00957 Make multiplatform compile shared app resources 2020-06-28 03:05:01 -05:00
Maurice Parker a6e75df412 Send out an event if we found a cached favicon downloader for new homepage URL. Issue #1940 2020-03-24 12:21:08 -05:00
Nate Weaver aad1fc4a0c Call the completion handler with nil if faviconURLs is nil
Fixes #1791.
2020-02-15 08:53:56 -06:00
Nate Weaver b3f736f899 Add a clarification comment 2020-02-15 08:22:59 -06:00
Nate Weaver ee48f4baba Remove redundant nil check for homePageURL 2020-02-15 08:22:51 -06:00
Nate Weaver 2ac4df4ee6 Use a single compactMap() instead of filter().compactMap() 2020-02-08 18:22:35 -06:00
Brent Simmons 2cdcddeefe Handle possible nil favicon.urlString. 2020-02-05 22:43:18 -08:00
Nate Weaver 0d128c0c3c Fix spacing 2020-02-02 17:53:46 -06:00
Nate Weaver 830db84c56 Explicitly import CoreServices
For UTType stuff; iOS doesn't implicitly import it.
2020-02-01 18:03:44 -06:00
Nate Weaver e9a3764270 Documentation comment 2020-02-01 18:03:44 -06:00
Nate Weaver 101e140233 Make ignoredTypes a static property to avoid redundant lookups 2020-02-01 18:03:44 -06:00
Nate Weaver f65bf63bb1 Add the ability to ignore types to FaviconURLFinder, and ignore SVG favicons 2020-02-01 18:03:44 -06:00
Nate Weaver 97049be067 Only add to the no-favicons cache if the only icon was the defaulted favicon.ico 2020-02-01 18:03:44 -06:00
Nate Weaver b088cda5a5 Fix homePageURLsWithNoFaviconURLCache 2020-02-01 18:03:44 -06:00
Nate Weaver 7ee1f99962 Updates for Data+RSCore changes 2020-01-18 19:18:58 -06:00
Nate Weaver b35215d03b Update for pending RSCore String updates 2020-01-17 13:45:38 -06:00
Nate Weaver 0b404c294d Update to newest RSCore 2020-01-09 18:22:06 -06:00
Maurice Parker 58b24f3349 Rename callback: to completion: 2019-12-14 18:01:34 -07:00
Nate Weaver 71bc1e5d8a Return the app icon earlier so we never hit the favicon cache 2019-12-07 16:09:32 -06:00
Nate Weaver bf4dd59d90 Use the app icon for the NNW feed 2019-12-07 15:45:33 -06:00
Nate Weaver 64af8840fe Mark appropriate caches as dirty 2019-11-27 15:45:14 -06:00
Nate Weaver f690bba775 Make sure self.postDidLoadFaviconNotification() is always called after a download attempt
Otherwise the rest of the favicon URLs won't be tried.
2019-11-27 15:40:35 -06:00
Maurice Parker ef2222ad94 Merge branch 'mac-release' 2019-11-27 14:08:52 -06:00
Nate Weaver 9de27febf0 Fix favicon loading for sites with multiple/invalid favicons
Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser
2019-11-27 13:02:49 -06:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 560f36621f Add IconImage to encapsulate our icon processing logic 2019-11-05 18:05:57 -06:00
Maurice Parker 8eb99b01c3 Increase default icon brightness 2019-10-31 14:25:09 -05:00