Commit Graph

1393 Commits

Author SHA1 Message Date
Maurice Parker 4075da2ee8 Fix removal of tap zones when removing old web views 2020-06-16 08:07:54 -05:00
Maurice Parker 3b2fcb74fd Merge pull request #2134 from Mackarous/master
Disable selection while applying snapshot
2020-06-15 17:23:23 -05:00
Andrew Mackarous 5cc2605add Fix issue #2132 2020-06-15 02:42:30 -04:00
Brian Sanders 6aa7b009f8 Tweaks the scroll behavior when space bar is pressed
The overlap is 2 lines of text at the standard system font size.
2020-06-13 19:17:17 -04:00
Kiel Gillard 🤪 9d7ebf8dfa Command + I can be used to get info on a feed for a timeline or an article. Fixes #2104 2020-05-26 14:52:15 +10:00
Maurice Parker 3ce20e26ff Merge pull request #2102 from stuartbreckenridge/issue-1932
Adds Title when sharing to Tweetbot and Buffer
2020-05-23 15:02:03 -05:00
Stuart Breckenridge 8b3e5d7cfd Adds Title when sharing to Tweetbot and Buffer
Fixes #1932
2020-05-22 20:53:22 +08:00
Stuart Breckenridge 98c8ea6d9f disables swipe back gesture on trackpads 2020-05-20 21:32:19 +08:00
Stuart Breckenridge 2297d218c0 Uses selector syntax. 2020-05-18 09:23:42 +08:00
Stuart Breckenridge 6224dfad03 Notification Permission Requests
Fixes #2057

• On app launch, the app checks if notification permissions are granted and registers with APNS if that is the case. It will not request permissions as part of the app launch.

• When a user requests to be notified of new articles, the authorizationStatus is checked:
- if `notDetermined` or `provisional`, an authorization request is made, and if successful, the Notify of New Articles status is updated (otherwise it is reverted)
- if `denied`, an alert is thrown asking the user to enable in settings (and the change to notify of new articles is reverted)
- if `authorized` the update is made.

`WebFeedInspectorViewController` also monitors for the app entering the foreground so that it can get the latest notification auth settings.
2020-05-18 08:39:22 +08:00
Maurice Parker c2b749a74c Rebuild backing stores immediately when deselecting a Feed. Issue #2079 2020-05-15 17:06:49 -05:00
Maurice Parker 4e22489d97 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-05-15 10:45:22 -05:00
Maurice Parker 8ff2776d88 Make sure we have only one web view in the view hierarchy after navigation. Issue #2075 2020-05-15 10:45:05 -05:00
Maurice Parker 225c98a70e Merge pull request #2073 from rizwankce/open-in-safari-shortcut
Keyboard shortcuts for "Open in App Browser"
2020-05-15 04:38:26 -05:00
Rizwan Mohamed Ibrahim c9ebb6bd75 adds "Open In App Browser" shortcut 2020-05-15 12:39:33 +05:30
Rizwan Mohamed Ibrahim 04458adee5 adds "Mark All Read" shortcut for feeds list 2020-05-14 18:13:41 +05:30
Rizwan Mohamed Ibrahim f7f7f4dddb adds keyboard shortcuts for open in Safari 2020-05-14 17:58:38 +05:30
Maurice Parker 8500324eb2 Merge pull request #2041 from stuartbreckenridge/mail-fix-ios
mailto links now open on iOS
2020-05-14 07:26:26 -05:00
Maurice Parker 8fe746fabf Merge pull request #2072 from rizwankce/fix/share-extension-activation-rule
Share extension activation rule for text
2020-05-14 07:17:54 -05:00
Maurice Parker 7deac7f3c3 Merge pull request #2071 from stuartbreckenridge/issue-2018
Key commands work with action sheets
2020-05-14 07:14:57 -05:00
Rizwan Mohamed Ibrahim bfef02e18f adds text activation rule for share extension 2020-05-14 17:17:16 +05:30
Stuart Breckenridge a9e8cec90e Key commands work with action sheets 2020-05-14 17:10:55 +08:00
Maurice Parker 8f8bd229c5 Merge pull request #2068 from rizwankce/feature/keyboard-shortcuts
Keyboard shortcuts
2020-05-13 11:43:14 -05:00
Rizwan Mohamed Ibrahim 32c8c038ee move toggle side bar to RootSplitViewController 2020-05-13 21:57:02 +05:30
Rizwan Mohamed Ibrahim a9aefd252e adds keyboard shortcuts
- toggle side bar on timeline
- toggle readers view on article
- go to settings on global
2020-05-13 17:29:59 +05:30
Stuart Breckenridge f153643273 Removes return statements that are not needed. 2020-05-13 13:03:51 +08:00
Stuart Breckenridge 58575331dd Fixes #2018
This commit adds a new `MarkAsReadAlertControllerSourceType` protocol to which `CGRect`, `UIView`, and `UIBarButtonItem` conform to.

The `MarkAsReadAlertController` now presents an action sheet for mark as read, mark above as read, and mark below as read. The above is used for the `popoverPresentationController`’s `barButtonItem`, `sourceRect`, or `sourceView` as needed.
2020-05-13 12:33:51 +08:00
Maurice Parker 46a96a7d50 Serialize access to the web view provider. Issue #2043 2020-05-07 11:32:11 -05:00
Maurice Parker 211e44fff5 Remove flash when changing out the web view upon returning to the foreground 2020-05-06 17:35:38 -05:00
Maurice Parker d4cffa28f2 Rollback disclosure button reference hold since it does nothing to stop the crash 2020-05-06 14:58:47 -05:00
Maurice Parker 502ff3e019 Don't multiply by the device pixel ratio if that will put us over the canvas limit 2020-05-06 14:55:34 -05:00
Maurice Parker 5f60b84b8b Reset all the web views when coming back to the foreground incase one of them is unavailable now 2020-05-06 14:53:09 -05:00
Stuart Breckenridge f58ac4d160 Wraps Alert strings in NSLocalizedString
Also removes `tel` scheme handling.
2020-05-04 13:25:02 +08:00
Stuart Breckenridge e825a5d516 Adds handling of tel url schemes 2020-05-03 22:37:01 +08:00
Stuart Breckenridge f901436211 mailto links now open on iOS
fixes #2036

Extends `URL` with an email address `var` for `mailto` schemes and adds a decisionHandler for `mailto` schemes on `WebViewController`. If the device cannot send mail, an alert is displayed.
2020-05-03 21:33:57 +08:00
Maurice Parker e2267d14ee Hold a reference to the pointer interaction to try to get it to stop crashing. Issue #2034 2020-05-01 16:34:19 -05:00
Maurice Parker d5a4f1625a Take device pixel ratio into consideration when drawing the image to zoom. Issue #2032 2020-05-01 16:24:29 -05:00
Maurice Parker 37bbee9fcc Remove calls to dismiss delegate function on cancel. Issue #2010 2020-04-28 17:58:06 -05:00
Maurice Parker e77abf42c3 Revert "Removes AddAccountDismissDelegate" 2020-04-28 17:53:24 -05:00
Maurice Parker 31f3487d7a Reset focus when returning to the app from another app or the safari view controller. Issue #1963 2020-04-28 17:16:34 -05:00
Maurice Parker 6f29b21ddc Merge pull request #2013 from rizwankce/fix/missing-add-account-title
Add title for AddAccountViewController
2020-04-24 10:30:31 -05:00
Rizwan Mohamed Ibrahim 54fc60aa51 Add title for AddAccountViewController
view controller title via storyboard
2020-04-24 20:56:29 +05:30
Maurice Parker a46609b564 Merge pull request #2014 from rizwankce/fix/add-account-cell-high-lighting
Deselect the cell row when selected for add account view controller
2020-04-24 09:11:28 -05:00
Rizwan Mohamed Ibrahim 43f175d71a Removes AddAccountDismissDelegate
Delegate which was responsible to dismiss AddAccountViewController
whenever presented view controller dismissed is not needed. So removing
it simply will go to previous screen from where user comes.
2020-04-24 18:49:49 +05:30
Rizwan Mohamed Ibrahim c7e3162c22 Deselect the cell row when selected for add account view controller
To avoid the highlighting even after the row is selected
2020-04-24 18:39:18 +05:30
Maurice Parker 947c4f04d7 Implement fix that prevents wiggling on both the timeline and the article views. 2020-04-22 22:03:15 -05:00
Maurice Parker a5583fc655 Validate that the selected row hasn't been removed when trying to select or scroll to it. Issue #1976 2020-04-22 18:18:20 -05:00
Maurice Parker 82e7d4eaf0 Merge branch 'ios-release' of https://github.com/Ranchero-Software/NetNewsWire into ios-release 2020-04-21 20:24:01 -05:00
Maurice Parker 2454b807bb Always update the status sync timer when returning to the foreground. Issue #2005 2020-04-21 20:23:46 -05:00
Rizwan Mohamed Ibrahim 108da4ccf4 Fix buttons a11y label for close and share button for image vc
Image View Controller buttons both close and share don't have correct
a11y label. This will add the localised label
2020-04-21 22:14:58 +05:30