Commit Graph

47 Commits

Author SHA1 Message Date
haikusw eae1eec246 rename to shorter version since we no longer need to distinguish between this and other dragOperation type. 2022-06-08 13:14:49 -07:00
Tyler 665e97232d Address 3580 by using only the items in the DraggingInfo to handle the drag and no view properties associated with a single window.
Remove cached `draggedNodes` optimization and just always use the data on the dragging pasteboard because it works both within the same window and across two windows.

Add support for WebFeedPasteboardWriter to include a parent containerName in the pasteboard dictionary written for a WebFeed object (which doesn't know about it's parent) because we need this for drag and drop to be able to perform a move operation.

Fix issue with dragged feeds not knowing their parent folder and delete deleting the wrong item by telling WebFeedPasteboardWriter what the container of items is.  Remove code that is now unused now that draggedNodes is removed and consolidate code that was expanded to handle both node and pasteboard items since we are just using pasteboard items now.
2022-06-04 20:24:48 -07:00
Maurice Parker ab5421f533 Merge branch 'mac-release' into main 2021-03-27 17:21:49 -05:00
Maurice Parker 52f11ff538 Add validateFeed parameter to createWebFeed 2021-03-15 18:01:12 -05:00
Maurice Parker f1e4d70481 Simplify the folder copy logic 2021-03-15 17:47:53 -05:00
Maurice Parker d57cb7b21f Delete obsolete code 2021-03-15 17:35:23 -05:00
Maurice Parker 7e4e7091e2 Delete obsolete code 2021-03-15 17:33:12 -05:00
Maurice Parker bf76cb810d Change to always copy between accounts. Fixes #2871 2021-03-11 19:43:05 -06:00
Maurice Parker 1f159a5bff Change drag-n-drop behavior to default to copy when dragging between accounts 2021-02-22 18:50:29 -06:00
Maurice Parker afd9a47abd Change so that we only show one error dialog when folder moves/copies can't find one or more feeds. 2021-02-22 17:50:30 -06:00
Maurice Parker 931b1f9afd Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-22 17:14:41 -06:00
Maurice Parker 731d0d0d88 Show Folder as it is created to give better visual feedback that a folder copy was successful. Fixes #2815 2021-02-16 14:24:21 -06:00
Maurice Parker 2395c0c7df Correct validation so that we can still move feeds in Reader API accounts 2020-10-31 17:37:25 -05:00
Maurice Parker 5fdbd4b9d0 Fixed misleading variable name 2020-10-31 17:31:48 -05:00
Maurice Parker cbb481c3f7 Don't allow a feed to be in more than one folder for Reader API accounts 2020-10-31 17:26:43 -05:00
Maurice Parker 0ff0c87932 Add the new twitter add dialog 2020-04-21 21:25:45 -05:00
Maurice Parker 06bd5b3a6f Renamed Feed and related classes/instances to WebFeed 2019-11-14 20:11:41 -06:00
Maurice Parker 1bcc1eda44 Implement disallowing feeds in the root folder for specified accounts 2019-09-20 15:37:10 -05:00
Maurice Parker af0d6c9022 Implement AccountBehaviors so that we don't have to keep adding boolean flags to account 2019-09-20 11:34:31 -05:00
Maurice Parker 74f84dc000 Restrict OPML import for Account types that don't support it 2019-06-19 17:50:32 -05:00
Maurice Parker 6527ac852c Correct usage of BatchUpdate so that UI remains responsive after error messages Issue #752 2019-06-13 14:50:41 -05:00
Maurice Parker beacad1aeb Validate folder drop to make sure no folders with the same name are already in the target account 2019-05-30 17:57:06 -05:00
Maurice Parker a8f090656d Handle when a feed in a folder being copied/moved already is subscribed in target account 2019-05-30 14:44:13 -05:00
Maurice Parker 30c21bb125 Enable folders to be dropped in a move or copy between accounts 2019-05-30 14:36:21 -05:00
Maurice Parker 1352dda8aa Modify Feedbin feed deletes so that they emulate how the local account feed deletes work. 2019-05-30 10:12:34 -05:00
Maurice Parker 51284b5aa4 Rename deleteFeed to removeFeed to be more consistent with other API's 2019-05-29 21:04:44 -05:00
Maurice Parker f4bc17c8f1 Refactor addFeed and removeFeed usages to be more consistent 2019-05-29 20:47:52 -05:00
Maurice Parker 5e3fcfd955 Correct how feeds were deleted so that only the feed in the correct container was deleted 2019-05-29 17:56:26 -05:00
Maurice Parker bead6ae123 Remove now unnecessary call to account structureDidChange in drop 2019-05-29 17:14:50 -05:00
Maurice Parker fa6b6a4769 Corrected move BatchUpdate usage to make move animation smoother 2019-05-29 17:08:41 -05:00
Maurice Parker b1bd8d2d90 Enable folder dragging between accounts 2019-05-29 15:43:33 -05:00
Maurice Parker 0648053417 Enforce tag specific drop validation (can't copy to the account level) 2019-05-28 17:42:19 -05:00
Maurice Parker 83652c40de Handle scenario where moved/copied feed already exists somewhere else in account 2019-05-28 16:46:16 -05:00
Maurice Parker 01d5a95241 Remove redundant private keyword usage 2019-05-28 16:31:03 -05:00
Maurice Parker 112702020b Enable same account copying. 2019-05-28 13:11:29 -05:00
Maurice Parker 78c19bda43 Remove restriction on only moving and copying between local accounts. 2019-05-28 11:09:47 -05:00
Maurice Parker b3c4c8de59 Correct how feeds were copied and moved between accounts to eliminate shared objects. 2019-05-28 10:59:06 -05:00
Maurice Parker c7b61f7d87 Enable copy between local accounts. 2019-05-27 18:01:24 -05:00
Maurice Parker 659c9e5271 Allow dragged feeds between local accounts only 2019-05-27 15:11:16 -05:00
Maurice Parker e6680a23b9 Make move animation smoother by wrapping in a BatchUpdate 2019-05-21 09:03:28 -05:00
Maurice Parker b759237fc1 Fix issue where moving from account to folder and the network is unavailable caused feeds to be lost. 2019-05-16 11:19:44 -05:00
Maurice Parker cda8acc66c Add the ability to move feeds between folders for Feedbin 2019-05-09 13:31:18 -05:00
Maurice Parker 50d3a5799c added subscription delete 2019-05-09 07:25:45 -05:00
Maurice Parker 133398c240 Prevent dragging between accounts. 2019-05-01 17:49:25 -05:00
Maurice Parker 78e98e4c03 Make single non-local drops work with multiple accounts 2019-05-01 17:33:08 -05:00
Maurice Parker 4bc7611721 Rename AccountManageer.localAccount to AccountManager.defaultAccount to make it different from other local accounts 2019-05-01 05:53:18 -05:00
Brent Simmons 70312aa75c Major folder and project tree restructuring. 2019-04-13 16:18:54 -07:00