Stuart Breckenridge
0dd4689bf0
Logging changes
...
- Adds `Logging` protocol
- Moves to Swift-style `OSLog` usage
os_log to Logger
os_log audit
Replacment of os.log with Logging
2022-09-04 21:31:03 +08:00
Maurice Parker
bff3c26490
Added missing protocol conformance
2022-07-26 17:40:19 -05:00
Daniel Jalkut
99797586b1
Add support for in-article find when the detail view is showing a regular article or extracted article content.
2022-07-18 13:04:10 -04:00
haikusw
3b9465f21e
Add #unavailable check so bug fix only executes in macOS 11. Add @available to flag when we can remove this bug-fix code altogether.
2022-06-20 23:12:56 -07:00
haikusw
4c7f1362b5
Fix for #3543
...
Noticed that the window size wasn't returning the new value and that's why using the window size to calculate the size to restore it to we were incrementing the original size by one.
Not sure if this breaks the fix that this bigSurOffsetFix was implementing though because I can't replicate that on macOS 12.4
2022-06-15 23:56:02 -07:00
Maurice Parker
b80d7dc24e
Merge pull request #3587 from haikusw/fix3580v2
...
Address #3580 by avoiding use of per-window properties.
2022-06-08 13:48:00 -07:00
haikusw
eae1eec246
rename to shorter version since we no longer need to distinguish between this and other dragOperation type.
2022-06-08 13:14:49 -07:00
Maurice Parker
6386a51f43
Merge pull request #3532 from Wevah/article-copy-order-fix
...
Return [Article] from articlesForIndexes() instead of Set<Article>
2022-06-08 12:44:45 -07:00
Tyler
665e97232d
Address 3580 by using only the items in the DraggingInfo to handle the drag and no view properties associated with a single window.
...
Remove cached `draggedNodes` optimization and just always use the data on the dragging pasteboard because it works both within the same window and across two windows.
Add support for WebFeedPasteboardWriter to include a parent containerName in the pasteboard dictionary written for a WebFeed object (which doesn't know about it's parent) because we need this for drag and drop to be able to perform a move operation.
Fix issue with dragged feeds not knowing their parent folder and delete deleting the wrong item by telling WebFeedPasteboardWriter what the container of items is. Remove code that is now unused now that draggedNodes is removed and consolidate code that was expanded to handle both node and pasteboard items since we are just using pasteboard items now.
2022-06-04 20:24:48 -07:00
Nate Weaver
ae09d52940
Return [Article] from articlesForIndexes() instead of Set<Article>
2022-04-17 15:26:37 -05:00
Ethan Wong
5e2fe5f610
Add proper OSLog argument for os_log calls.
2022-04-04 13:51:53 +08:00
Sean Santry
f802165959
Save Sidebar open/collapsed state between launches. Fixes #2707
2022-01-30 22:31:43 -05:00
Maurice Parker
ae33228fe3
Merge branch 'main' into ios-6.2
2022-01-22 11:14:30 -08:00
Maurice Parker
2eb82af473
Merge pull request #3413 from J-rg/fix-3268
...
Fix blurry sidebar symbols (#3268 )
2022-01-22 09:32:38 -08:00
Stuart Breckenridge
b08d9dfe73
if #available mac
...
Removes if #available for anything less than macOS 11
2022-01-22 20:55:09 +08:00
J-rg
b11db14017
Fix blurry sidebar symbols ( #3268 )
2022-01-22 03:53:50 +01:00
Stuart Breckenridge
d680fe0988
WKWebpagePreferences added to macOS
2022-01-22 08:39:57 +08:00
Ethan Wong
06278879bc
Fix: bottom inset of TimelineTableView disappeared on macOS Monterey
2022-01-10 08:16:42 +08:00
Dimitris Apostolou
94ae4d348c
Fix typos
2022-01-05 00:25:20 +02:00
Maurice Parker
09652bff81
Remove Mark Read on Scroll code
2021-12-29 14:44:40 -08:00
Maurice Parker
06eae25797
Merge pull request #3329 from everhardt/feat-1844-scroll-mark-as-read
...
Add mark as read on scroll
2021-11-04 12:04:53 -05:00
Maurice Parker
c26f09ad1c
Fix bug that prevented us from returning to the original text size
2021-11-01 21:24:56 -05:00
everhardt
96ffa3aa22
Do not mark as read without user interaction
2021-10-30 18:57:04 +02:00
everhardt
5364b4f384
Mark bottom items in feed as read after 2 seconds on Mac
...
In case markArticlesAsReadOnScroll is set
2021-10-30 10:58:12 +02:00
everhardt
3b6a3cf4e7
Do not mark articles as read on scroll when they were manually toggled
2021-10-30 10:37:10 +02:00
everhardt
8bce42df56
Change scrollPositionQueue in Mac TimelineViewController to private
2021-10-27 22:21:42 +02:00
everhardt
3db1b60b65
Add Mac setting for mark as read on scroll
2021-10-27 22:03:38 +02:00
everhardt
7b8bed9ac2
Add mark as read on scroll functionality
...
Does not yet include a setting
2021-10-27 20:52:26 +02:00
Maurice Parker
6e54598547
Fix type that caused a compile error
2021-09-30 09:43:32 -05:00
Duncan Babbage
f6552e110d
Replace raw with repaired links. Fixes #3103
2021-09-30 16:52:00 +13:00
Duncan Babbage
cc855f3832
link and URL vars for Article. Storage as rawLink
...
link and externalLink fall back to providing the raw stored value if URLs cannot be created even with repair.
2021-09-30 16:51:59 +13:00
Maurice Parker
4a3934fd28
Add ellipsis to Add context menu
2021-09-23 11:57:47 -05:00
Maurice Parker
b43d8b6b28
Change reload so that the text size style can be used in more places.
2021-09-17 15:59:43 -05:00
Maurice Parker
de956f9473
Change to use JavaScript to detect scroll events as it will also capture scrollbar events
2021-09-13 21:03:27 -05:00
Maurice Parker
2c801a388c
Restore the article scroll position when restarting NetNewsWire
2021-09-13 20:42:58 -05:00
Maurice Parker
87700325cf
Changed to use preferredURL incase we run into any malformed links
2021-09-12 21:34:47 -05:00
Maurice Parker
fa4b2531f8
Merge pull request #3102 from robmathers/copy-url-menu-options
...
Add Copy Article URL & Copy External URL Menu Items. Fixes #1285 .
2021-09-12 21:17:50 -05:00
Maurice Parker
abd66ea1bb
Maintain scroll position when changing themes
2021-09-11 20:53:57 -05:00
Maurice C Parker
c031aa5cbe
Add popup button for selecting article themes on Catalina
2021-09-09 05:47:49 -05:00
Maurice Parker
39c9cc440c
Add optional article theme toolbar item
2021-09-08 19:58:40 -05:00
Maurice Parker
596202fc33
Reload the article if the theme changes
2021-09-08 15:55:42 -05:00
Maurice Parker
b568f03edc
Unify the stylesheets into a single one to make building themes easier
2021-09-08 04:58:26 -05:00
Maurice Parker
512e83d786
Refactor Styles to now be Themes
2021-09-07 16:58:06 -05:00
Daniel Jalkut
2e652351ec
Implement the WKUIDelegate method that is reached when JavaScript in a web view invokes window.open(). This ensures that attempts to open links from code, such as from the YouTube embedded video player, work as expected. Fixes #3088 .
2021-07-27 17:34:48 -04:00
Maurice Parker
f9af3c786b
Merge branch 'ios-candidate'
2021-05-25 20:12:50 -05:00
Brent Simmons
9d2c8f000f
Create and use IconImageCache. It centralizes and de-dupes logic for getting feed/article images, and it caches the results, which helps performance.
2021-05-08 12:42:44 -07:00
Rob Mathers
8707a71313
Add Copy Article URL & Copy External URL Menu Items
...
The Mac items display in the edit and contextual menus, and in the iOS contextual menu for an article.
2021-05-01 16:47:39 -04:00
Chris Campbell
364f3a7639
Prevent infinite loop in DetailWebView.setFrameSize()
...
DetailWebView.setFrameSize() calls bigSurOffsetFix(), which changes the window's frame, which ultimately calls setFrameSize() again (which calls bigSurOffsetFix(), etc). In practice, this isn't causing an infinite loop (I think NSWindow.setFrame(_:display:) is smart enough to prevent reentrancy) but it's still dangerous to have such a glaring logic error in the code.
2021-04-30 00:52:15 -04:00
Chris Campbell
bf77d77669
Expand workaround for macOS 11 WebView origin offset bug. Fixes #2916
...
Move the code that twiddles the window frame from DetailWebView.viewDidEndLiveResize() into a new bigSurOffsetFix() API so it can also be called by setFrameSize() when the frame size is changed outside of a live resize.
2021-04-30 00:02:10 -04:00
Duncan Babbage
9092d075a0
Handle links with unencoded spaces. Fixes #3069
2021-04-28 22:49:32 +12:00
