From 25716828861a550b9b4c8b2fc42771c645cf01a8 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Thu, 11 May 2023 00:07:34 -0500 Subject: [PATCH] Fix pessimizing move warnings on Clang --- src/config.cpp | 5 +---- src/stream.cpp | 8 ++++---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/config.cpp b/src/config.cpp index f2028f47..5d5f1f87 100644 --- a/src/config.cpp +++ b/src/config.cpp @@ -832,10 +832,7 @@ namespace config { auto undo_cmd = prep_cmd.get_optional("undo"s); auto elevated = prep_cmd.get_optional("elevated"s); - input.emplace_back( - std::move(do_cmd.value_or("")), - std::move(undo_cmd.value_or("")), - std::move(elevated.value_or(false))); + input.emplace_back(do_cmd.value_or(""), undo_cmd.value_or(""), elevated.value_or(false)); } } diff --git a/src/stream.cpp b/src/stream.cpp index 84682e6b..18c1473c 100644 --- a/src/stream.cpp +++ b/src/stream.cpp @@ -1475,8 +1475,8 @@ namespace stream { // Enable QoS tagging on video traffic if requested by the client if (session->config.videoQosType) { auto address = session->video.peer.address(); - session->video.qos = std::move(platf::enable_socket_qos(ref->video_sock.native_handle(), address, - session->video.peer.port(), platf::qos_data_type_e::video)); + session->video.qos = platf::enable_socket_qos(ref->video_sock.native_handle(), address, + session->video.peer.port(), platf::qos_data_type_e::video); } BOOST_LOG(debug) << "Start capturing Video"sv; @@ -1500,8 +1500,8 @@ namespace stream { // Enable QoS tagging on audio traffic if requested by the client if (session->config.audioQosType) { auto address = session->audio.peer.address(); - session->audio.qos = std::move(platf::enable_socket_qos(ref->audio_sock.native_handle(), address, - session->audio.peer.port(), platf::qos_data_type_e::audio)); + session->audio.qos = platf::enable_socket_qos(ref->audio_sock.native_handle(), address, + session->audio.peer.port(), platf::qos_data_type_e::audio); } BOOST_LOG(debug) << "Start capturing Audio"sv;