From 039eea17ae9fc2e38b2a9ab879db24c74110a484 Mon Sep 17 00:00:00 2001 From: chrox Date: Sun, 24 Mar 2013 18:28:54 +0800 Subject: [PATCH] bugfix: set toc/bookmark window dimension smaller than screen size Otherwise if text widgets in toc window expands out of screen, memory free on these widgets will mess up the heap. It sounds ridiculous but after we restrict toc window well inside the screen the bug in #815 is fixed. --- frontend/ui/reader/readerbookmark.lua | 4 ++-- frontend/ui/reader/readertoc.lua | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/ui/reader/readerbookmark.lua b/frontend/ui/reader/readerbookmark.lua index 8dc05530e..a0c90d12e 100644 --- a/frontend/ui/reader/readerbookmark.lua +++ b/frontend/ui/reader/readerbookmark.lua @@ -89,8 +89,8 @@ function ReaderBookmark:onShowBookmark() local bm_menu = Menu:new{ title = "Bookmarks", item_table = self.bookmarks, - width = Screen:getWidth()-20, - height = Screen:getHeight(), + width = Screen:getWidth()-50, + height = Screen:getHeight()-50, } -- buid up menu widget method as closure local doc = self.ui.document diff --git a/frontend/ui/reader/readertoc.lua b/frontend/ui/reader/readertoc.lua index d3c5c4603..355ca5483 100644 --- a/frontend/ui/reader/readertoc.lua +++ b/frontend/ui/reader/readertoc.lua @@ -85,8 +85,8 @@ function ReaderToc:onShowToc() title = "Table of Contents", item_table = self.toc, ui = self.ui, - width = Screen:getWidth()-20, - height = Screen:getHeight(), + width = Screen:getWidth()-50, + height = Screen:getHeight()-50, show_parent = menu_container, }