From 075edf998069fe0d6ccc6fc82d9454eb0b36f085 Mon Sep 17 00:00:00 2001 From: Benoit Pierre Date: Thu, 9 May 2024 02:36:45 +0200 Subject: [PATCH] tests/readerhighlight: speedup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reduce time to run those tests by 74% on my machine (~8.8s → ~2.3s). --- spec/unit/readerhighlight_spec.lua | 39 ++++++++++++------------------ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/spec/unit/readerhighlight_spec.lua b/spec/unit/readerhighlight_spec.lua index e23c9c797..ea2a63bcf 100644 --- a/spec/unit/readerhighlight_spec.lua +++ b/spec/unit/readerhighlight_spec.lua @@ -30,14 +30,11 @@ describe("Readerhighlight module", function() -- Reset in case we're called more than once. readerui.languagesupport.improveWordSelection:revert() - UIManager:scheduleIn(1, function() - UIManager:close(readerui.dictionary.dict_window) - UIManager:close(readerui) - -- We haven't torn it down yet - ReaderUI.instance = readerui - UIManager:quit() - end) - UIManager:run() + UIManager:close(readerui.dictionary.dict_window) + UIManager:close(readerui) + -- We haven't torn it down yet + ReaderUI.instance = readerui + UIManager:quit() end local function highlight_text(readerui, pos0, pos1) readerui.highlight:onHold(nil, { pos = pos0 }) @@ -56,14 +53,11 @@ describe("Readerhighlight module", function() assert.truthy(UIManager._window_stack[next_slot].widget == readerui.highlight.highlight_dialog) readerui.highlight:saveHighlight() - UIManager:scheduleIn(1, function() - UIManager:close(readerui.highlight.highlight_dialog) - UIManager:close(readerui) - -- We haven't torn it down yet - ReaderUI.instance = readerui - UIManager:quit() - end) - UIManager:run() + UIManager:close(readerui.highlight.highlight_dialog) + UIManager:close(readerui) + -- We haven't torn it down yet + ReaderUI.instance = readerui + UIManager:quit() end local function tap_highlight_text(readerui, pos0, pos1, pos2) readerui.highlight:onHold(nil, { pos = pos0 }) @@ -74,14 +68,11 @@ describe("Readerhighlight module", function() UIManager:close(readerui.highlight.highlight_dialog) readerui.highlight:onTap(nil, { pos = pos2 }) assert.truthy(readerui.highlight.edit_highlight_dialog) - UIManager:nextTick(function() - UIManager:close(readerui.highlight.edit_highlight_dialog) - UIManager:close(readerui) - -- We haven't torn it down yet - ReaderUI.instance = readerui - UIManager:quit() - end) - UIManager:run() + UIManager:close(readerui.highlight.edit_highlight_dialog) + UIManager:close(readerui) + -- We haven't torn it down yet + ReaderUI.instance = readerui + UIManager:quit() end describe("highlight for EPUB documents", function()