From 67ae10742aa1f0994a1cab59a8d7fc87c0cf48ee Mon Sep 17 00:00:00 2001 From: Qingping Hou Date: Fri, 14 Oct 2016 17:03:44 -0700 Subject: [PATCH 1/3] defaults: try parse int from user input --- frontend/apps/filemanager/filemanagersetdefaults.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/apps/filemanager/filemanagersetdefaults.lua b/frontend/apps/filemanager/filemanagersetdefaults.lua index 6d861321c..3bbfecd56 100644 --- a/frontend/apps/filemanager/filemanagersetdefaults.lua +++ b/frontend/apps/filemanager/filemanagersetdefaults.lua @@ -176,7 +176,8 @@ function SetDefaults:init() callback = function() local new_table = {} for _, field in ipairs(MultiInputDialog:getFields()) do - new_table[field:match("^[^= ]+")] = field:match("[^= ]+$") + local key, value = field:match("^[^= ]+"), field:match("[^= ]+$") + new_table[tonumber(key) or key] = tonumber(value) or value end _G[setting_name] = new_table @@ -193,7 +194,6 @@ function SetDefaults:init() }, }, }, - input_type = "number", width = Screen:getWidth() * 0.95, height = Screen:getHeight() * 0.2, } From 31d22dfc1771ec731e47c5a6b490ac2a141565c2 Mon Sep 17 00:00:00 2001 From: Qingping Hou Date: Fri, 14 Oct 2016 19:51:24 -0700 Subject: [PATCH 2/3] fix(kobofrontligh): initialize dimen with nil value --- frontend/apps/reader/modules/readerkobolight.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/apps/reader/modules/readerkobolight.lua b/frontend/apps/reader/modules/readerkobolight.lua index cd98a78b6..2f3efda69 100644 --- a/frontend/apps/reader/modules/readerkobolight.lua +++ b/frontend/apps/reader/modules/readerkobolight.lua @@ -20,7 +20,7 @@ local ReaderKoboLight = InputContainer:new{ function ReaderKoboLight:init() self[1] = LeftContainer:new{ - dimen = Geom:new{w = Screen:getWidth(), h = Screen:getHeight()}, + dimen = Geom:new{w = nil, h = nil}, } self:resetLayout() end From 5309a0a47f12b246af11b0c4f8c494e1cb2d1844 Mon Sep 17 00:00:00 2001 From: Qingping Hou Date: Fri, 14 Oct 2016 20:36:00 -0700 Subject: [PATCH 3/3] misc: rotate crash.log for kobo/kindle/pocketbook --- platform/kindle/koreader.sh | 6 +++++- platform/kobo/koreader.sh | 5 ++++- platform/pocketbook/koreader.app | 5 ++++- reader.lua | 12 ++++++++++++ 4 files changed, 25 insertions(+), 3 deletions(-) diff --git a/platform/kindle/koreader.sh b/platform/kindle/koreader.sh index 339813166..4456281f7 100755 --- a/platform/kindle/koreader.sh +++ b/platform/kindle/koreader.sh @@ -243,7 +243,11 @@ logmsg "Starting KOReader . . ." if [ "${FROM_KUAL}" == "yes" ] ; then eips_print_bottom_centered "Starting KOReader . . ." 1 fi -./reader.lua "$@" > crash.log 2>&1 + +# we keep maximum 100K worth of crash log +cat crash.log &> /dev/null | tail -c 100000000 > crash.log.new +mv -f crash.log.new crash.log +./reader.lua "$@" >> crash.log 2>&1 # clean up our own process tree in case the reader crashed (if needed, to avoid flooding KUAL's log) if pidof reader.lua > /dev/null 2>&1 ; then diff --git a/platform/kobo/koreader.sh b/platform/kobo/koreader.sh index 601f58cc8..9d0c6fb78 100755 --- a/platform/kobo/koreader.sh +++ b/platform/kobo/koreader.sh @@ -111,7 +111,10 @@ if awk '$4~/(^|,)ro($|,)/' /proc/mounts | grep ' /mnt/sd ' ; then mount -o remount,rw /mnt/sd fi -./reader.lua "${args}" > crash.log 2>&1 +# we keep maximum 100K worth of crash log +cat crash.log &> /dev/null | tail -c 100000000 > crash.log.new +mv -f crash.log.new crash.log +./reader.lua "${args}" >> crash.log 2>&1 if [ "${FROM_NICKEL}" = "true" ] ; then if [ "${FROM_KFMON}" != "true" ] ; then diff --git a/platform/pocketbook/koreader.app b/platform/pocketbook/koreader.app index 6853e2bf7..a3651c2e1 100755 --- a/platform/pocketbook/koreader.app +++ b/platform/pocketbook/koreader.app @@ -33,7 +33,10 @@ else args="$@" fi -./reader.lua "$args" > crash.log 2>&1 +# we keep maximum 100K worth of crash log +cat crash.log &> /dev/null | tail -c 100000000 > crash.log.new +mv -f crash.log.new crash.log +./reader.lua "$args" >> crash.log 2>&1 if pidof reader.lua > /dev/null 2>&1 ; then killall -TERM reader.lua diff --git a/reader.lua b/reader.lua index 06044d639..f9d4874de 100755 --- a/reader.lua +++ b/reader.lua @@ -1,4 +1,16 @@ #!./luajit +print(string.format([[ +--------------------------------------------- + launching... + _ _____ ____ _ + | |/ / _ \| _ \ ___ __ _ __| | ___ _ __ + | ' / | | | |_) / _ \/ _` |/ _` |/ _ \ '__| + | . \ |_| | _ < __/ (_| | (_| | __/ | + |_|\_\___/|_| \_\___|\__,_|\__,_|\___|_| + + [*] Current time: %s +]], os.date("%x-%X"))) + -- load default settings require "defaults"