renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix connection bug with non-ASCII SSIDs in wpa_supplicant (#11089)

Browse Source 
* Bump base

includes:

koreader/koreader-base#1691
koreader/koreader-base#1692
koreader/koreader-base#1689
koreader/koreader-base#1690
koreader/koreader-base#1693

* Integrate decoding of SSIDs within wpa_supplicant

The UTF-8 decoding of SSIDs is specific to wpa_supplicant. In this
patch, we move all of this decoding logic to the wpa_supplicant module.
We expose the raw bytes of the SSID to the NetworkMgr code, and make
sure to always fix bad UTF-8 before we display the SSID to the user.

Within the wpa_supplicant module, we replace the call to the
wpa_passphrase binary to get the PSK with a direct function call to
OpenSSL. This allows us to calculate the PSK over any arbitrary bytes,
including UTF-8. In the same vein, we use the hex-encoded SSID to
communicate with wpa_supplicant when setting up the network to support
arbitrary bytes in the SSID.

Unfortunately, we also remove the tests, as there is no way to unit test
local functions.
This commit is contained in:
Wim de With
2023-11-09 21:08:26 +01:00
committed by GitHub
parent d0d3cf78f9
commit 17a4aa962f
5 changed files with 34 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
spec/unit/network_manager_spec.lua
View File

@@ -73,30 +73,6 @@ describe("network_manager module", function()
assert.is.same(release_ip_called, 0)
end)
describe("decodeSSID()", function()
local NetworkMgr = require("ui/network/manager")
it("should correctly unescape emoji", function()
assert.is_equal("📚", NetworkMgr.decodeSSID("\\xf0\\x9f\\x93\\x9a"))
end)
it("should correctly unescape multiple characters", function()
assert.is_equal("神舟五号", NetworkMgr.decodeSSID("\\xe7\\xa5\\x9e\\xe8\\x88\\x9f\\xe4\\xba\\x94\\xe5\\x8f\\xb7"))
end)
it("should ignore escaped backslashes", function()
assert.is_equal("\\x61", NetworkMgr.decodeSSID("\\\\x61"))
end)
it("should not remove encoded backslashes", function()
assert.is_equal("\\\\", NetworkMgr.decodeSSID("\\x5c\\"))
end)
it("should deal with invalid UTF-8 (relatively) gracefully", function()
assert.is_equal("<EFBFBD><EFBFBD>", NetworkMgr.decodeSSID("\\xe2\\x82"))
end)
end)
teardown(function()
function Device:initNetworkManager() end
function Device:hasWifiRestore() return false end