renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cre: Footnotes popup: fix markers disappearing too early

Browse Source 
When following a footnote popup, the highlighted link
delayed clearing (when the link is hidden by the popup)
would clear the margin marker on the target page too early.
This commit is contained in:
poire-z
2019-03-13 13:01:22 +01:00
parent 1945e181c5
commit 1a4faad17c
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/apps/reader/modules/readerlink.lua
View File

@@ -1062,9 +1062,15 @@ function ReaderLink:showAsFootnotePopup(link, neglect_current_location)
UIManager:setDirty(self.dialog, "ui")
close_callback = function(footnote_height)
-- remove this highlight (actually all) on close
local highlight_page = self.ui.document:getCurrentPage()
local clear_highlight = function()
self.ui.document:highlightXPointer()
UIManager:setDirty(self.dialog, "ui")
-- Only refresh if we stayed on the same page, otherwise
-- this could remove too early a marker on the target page
-- after this footnote is followed
if self.ui.document:getCurrentPage() == highlight_page then
UIManager:setDirty(self.dialog, "ui")
end
end
if footnote_height then
-- If the link was hidden by the footnote popup,