From 1aefd80ea60f1502a2798766d9d028681d3a482e Mon Sep 17 00:00:00 2001 From: SomeGuy <97603719+Commodore64user@users.noreply.github.com> Date: Mon, 27 May 2024 11:04:24 +0100 Subject: [PATCH] ReaderBookmark: "bookmark current page" removed from NT kindles (#11907) Discussed https://github.com/koreader/koreader/issues/11834#issuecomment-2132411929 onwards. --- frontend/apps/reader/modules/readerbookmark.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/apps/reader/modules/readerbookmark.lua b/frontend/apps/reader/modules/readerbookmark.lua index 10e531ba4..45dfa0900 100644 --- a/frontend/apps/reader/modules/readerbookmark.lua +++ b/frontend/apps/reader/modules/readerbookmark.lua @@ -66,6 +66,7 @@ function ReaderBookmark:onGesture() end function ReaderBookmark:registerKeyEvents() if Device:hasKeyboard() then self.key_events.ShowBookmark = { { "B" } } + self.key_events.ToggleBookmark = { { "Shift", "Right" } } elseif Device:hasScreenKB() then self.key_events.ShowBookmark = { { "ScreenKB", "Left" } } self.key_events.ToggleBookmark = { { "ScreenKB", "Right" } } @@ -102,7 +103,7 @@ function ReaderBookmark:addToMainMenu(menu_items) self:onShowBookmark() end, } - if not Device:isTouchDevice() then + if not Device:isTouchDevice() and not ( Device:hasScreenKB() or Device:hasSymKey() ) then menu_items.toggle_bookmark = { text_func = function() return self:isPageBookmarked() and _("Remove bookmark for current page") or _("Bookmark current page")