renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Touch zones: fix loss of overrides when re-registering a zone (#5658)

Browse Source 
Happens with "Inverse reading order", which re-registers
the Reader tap forward/backward zones and would prevent
tap menu and bookmark from working.
Before, when removing them, we would lose all the override=
set on them by other touch zones (tap menu, bookmarks...),
and so they were no more ensured after re-adding the zone.
So, make sure we don't lose that info.
This commit is contained in:
poire-z
2019-11-30 17:38:28 +01:00
committed by GitHub
parent 2541440bb8
commit 3d191490d0
3 changed files with 51 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/apps/reader/modules/readergesture.lua
View File

@@ -1577,11 +1577,6 @@ function ReaderGesture:onToggleReadingOrder()
local document_module = self.ui.document.info.has_pages and self.ui.paging or self.ui.rolling
document_module.inverse_reading_order = not document_module.inverse_reading_order
document_module:setupTouchZones()
-- Needed to reset the touch zone overrides
local gesture_manager = G_reader_settings:readSetting(self.ges_mode)
for gesture, action in pairs(gesture_manager) do
self:setupGesture(gesture, action)
end
UIManager:show(Notification:new{
text = document_module.inverse_reading_order and _("RTL page turning.") or _("LTR page turning."),
timeout = 2.5,