renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some issues with movable dict window (reworked) (#3726)

Browse Source 
Clearer rework of this fix (a few commits ago): more explicite,
no need for the additional callback.
This commit is contained in:
poire-z
2018-03-07 15:59:59 +01:00
committed by GitHub
parent e15a1ab1b3
commit 48da3dc750
3 changed files with 44 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/ui/widget/htmlboxwidget.lua
View File

@@ -148,20 +148,23 @@ function HtmlBoxWidget:getPosFromAbsPos(abs_pos)
return pos
end
function HtmlBoxWidget:onHoldStartText(callback, ges)
function HtmlBoxWidget:onHoldStartText(_, ges)
self.hold_start_pos = self:getPosFromAbsPos(ges.pos)
if not self.hold_start_pos then
if callback then
callback(false) -- let know we are not selecting
end
return false -- let event be processed by other widgets
end
self.hold_start_tv = TimeVal.now()
if callback then
callback(true) -- let know we are selecting
return true
end
function HtmlBoxWidget:onHoldPan(_, ges)
-- We don't highlight the currently selected text, but just let this
-- event pop up if we are not currently selecting text
if not self.hold_start_pos then
return false
end
return true
end