From 4e233aafc0a7cdf5e1f39f399eba92579d71565d Mon Sep 17 00:00:00 2001 From: NiLuJe Date: Thu, 27 Oct 2022 22:28:20 +0200 Subject: [PATCH] AutoSuspend: Update the standby help message. Tone it down for everyone, as it's been running smoothly for a while now, but add a dedicated extra warning on buggy boards that it might randomly implode. --- plugins/autosuspend.koplugin/main.lua | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/autosuspend.koplugin/main.lua b/plugins/autosuspend.koplugin/main.lua index 36208a782..d4214e37c 100644 --- a/plugins/autosuspend.koplugin/main.lua +++ b/plugins/autosuspend.koplugin/main.lua @@ -528,14 +528,16 @@ function AutoSuspend:addToMainMenu(menu_items) } end if Device:canStandby() then - --- @fixme: Reword the final warning when we have more data on the hangs on some Kobo kernels (e.g., #9038). local standby_help = _([[Standby puts the device into a power-saving state in which the screen is on and user input can be performed. Standby can not be entered if Wi-Fi is on. -Upon user input, the device needs a certain amount of time to wake up. Generally, the newer the device, the less noticeable this delay will be, but it can be fairly aggravating on slower devices. - -This is experimental on most devices, except those running on a sunxi SoC (Kobo Elipsa & Sage), so much so that it might in fact hang some of the more broken kernels out there (Kobo Libra 2).]]) +Upon user input, the device needs a certain amount of time to wake up. Generally, the newer the device, the less noticeable this delay will be, but it can be fairly aggravating on slower devices.]]) + -- Add a big fat warning on unreliable NTX boards + if Device:isKobo() and not Device:hasReliableMxcWaitFor() then + standby_help = standby_help .. "\n" .. + _([[Your device is known to be extremely unreliable, as such, failure to enter a power-saving state *may* hang the kernel, resulting in a full device hang or a device restart.]]) + end menu_items.autostandby = { sorting_hint = "device",