From 512065fa14945a75ec228b9bbe31d379398f20fc Mon Sep 17 00:00:00 2001 From: SomeGuy <97603719+Commodore64user@users.noreply.github.com> Date: Fri, 31 May 2024 21:36:03 +0100 Subject: [PATCH] ReaderLink: make AddCurrentLocationToStack always show notification when activated via keypress (#11925) As seen here https://github.com/koreader/koreader/pull/11900#discussion_r1615474301. --- frontend/apps/reader/modules/readerlink.lua | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/frontend/apps/reader/modules/readerlink.lua b/frontend/apps/reader/modules/readerlink.lua index 4f2e970c1..05ad3e773 100644 --- a/frontend/apps/reader/modules/readerlink.lua +++ b/frontend/apps/reader/modules/readerlink.lua @@ -236,11 +236,11 @@ function ReaderLink:registerKeyEvents() if Device:hasScreenKB() or Device:hasSymKey() then self.key_events.GotoSelectedPageLink = { { "Press" }, event = "GotoSelectedPageLink" } if Device:hasKeyboard() then - self.key_events.AddCurrentLocationToStack = { { "Shift", "Press" } } + self.key_events.AddCurrentLocationToStackNonTouch = { { "Shift", "Press" } } self.key_events.SelectNextPageLink = { { "Shift", "LPgFwd" }, event = "SelectNextPageLink" } self.key_events.SelectPrevPageLink = { { "Shift", "LPgBack" }, event = "SelectPrevPageLink" } else - self.key_events.AddCurrentLocationToStack = { { "ScreenKB", "Press" } } + self.key_events.AddCurrentLocationToStackNonTouch = { { "ScreenKB", "Press" } } self.key_events.SelectNextPageLink = { { "ScreenKB", "LPgFwd" }, event = "SelectNextPageLink" } self.key_events.SelectPrevPageLink = { { "ScreenKB", "LPgBack" }, event = "SelectPrevPageLink" } end @@ -718,6 +718,13 @@ function ReaderLink:onAddCurrentLocationToStack(show_notification) if show_notification then Notification:notify(_("Current location added to history.")) end + return true +end + +function ReaderLink:onAddCurrentLocationToStackNonTouch() + self:addCurrentLocationToStack() + Notification:notify(_("Current location added to history."), Notification.SOURCE_ALWAYS_SHOW) + return true end -- Remember current location so we can go back to it