renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[fix] "Follow Link" popup issues (#3198)

Browse Source 
* Add current location to location stack from follow link popup
  See https://github.com/koreader/koreader/pull/3190#issuecomment-328332771
* Word highlight not removed
* "Follow Link" not translated
* Typo in docs
This commit is contained in:
Frans de Jonge
2017-09-10 14:26:49 +02:00
committed by GitHub
parent 392209c200
commit 7310937219
3 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/apps/reader/modules/readerhighlight.lua
View File

@@ -3,7 +3,6 @@ local ConfirmBox = require("ui/widget/confirmbox")
local Device = require("device")
local Event = require("ui/event")
local InputContainer = require("ui/widget/container/inputcontainer")
local ReaderLink = require("apps/reader/modules/readerlink")
local UIManager = require("ui/uimanager")
local logger = require("logger")
local _ = require("gettext")
@@ -251,9 +250,7 @@ function ReaderHighlight:onHold(arg, ges)
if ok and word then
logger.dbg("selected word:", word)
self.selected_word = word
ReaderLink.ui = self.ui
ReaderLink.view = self.view
local link = ReaderLink:getLinkFromGes(ges)
local link = self.ui.link:getLinkFromGes(ges)
self.selected_link = nil
if link then
logger.dbg("link:", link)
@@ -392,7 +389,7 @@ function ReaderHighlight:onHoldRelease()
text = _("Follow Link"),
enabled = self.selected_link ~= nil,
callback = function()
ReaderLink:onGotoLink(self.selected_link)
self.ui.link:onGotoLink(self.selected_link)
UIManager:close(self.highlight_dialog)
end,
},