From 766ec91a84d1bd1e441e9d3d586cb18c5692a6f9 Mon Sep 17 00:00:00 2001 From: NiLuJe Date: Tue, 30 Mar 2021 20:01:38 +0200 Subject: [PATCH] ReaderFooter: Workaround a bad interaction with ReaderHighlight (#7466) Related to hold handlers. Fix #7464 --- frontend/apps/reader/modules/readerfooter.lua | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/frontend/apps/reader/modules/readerfooter.lua b/frontend/apps/reader/modules/readerfooter.lua index 97cc3a7fd..265adca60 100644 --- a/frontend/apps/reader/modules/readerfooter.lua +++ b/frontend/apps/reader/modules/readerfooter.lua @@ -2161,6 +2161,11 @@ function ReaderFooter:onTapFooter(ges) end function ReaderFooter:onHoldFooter() + -- We're lower priority than readerhighlight_hold, which means it's already been tripped by the time we got here. + -- If it actually had something to do, ReaderHighlight would have stopped propagating the event, + -- so we can safely clear ReaderHighlight state here, otherwise it'll get confused on the next tap... + -- (c.f., #7464) + self.ui.highlight:clear() if self.mode == self.mode_list.off then return end if self.settings.skim_widget_on_hold then self.ui:handleEvent(Event:new("ShowSkimtoDialog"))