From 8e038080472778e5b400a0a896e1cc2a5fe6f101 Mon Sep 17 00:00:00 2001 From: Frans de Jonge Date: Mon, 14 Apr 2025 17:12:46 +0200 Subject: [PATCH] NetworkManager: check if proxy URL can be parsed (#13562) Closes #12839. --- frontend/ui/network/manager.lua | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/frontend/ui/network/manager.lua b/frontend/ui/network/manager.lua index 1e307b999..23997a8c2 100644 --- a/frontend/ui/network/manager.lua +++ b/frontend/ui/network/manager.lua @@ -900,6 +900,14 @@ function NetworkMgr:getProxyMenuTable() title = _("Enter proxy address"), hint = proxy(), callback = function(input) + local url = require("socket.url") + local parsed = url.parse(input) + if not parsed or not parsed.scheme or not parsed.host or not parsed.port then + UIManager:show(InfoMessage:new{ + text = _("Invalid proxy address"), + }) + return false + end self:setHTTPProxy(input) end, },