MenuSorter: some documentation

MenuSorter: forgot to add plugin style change

MenuSorter: worked out the final quirks

* Menu always compressed into tables without missing indexes for ipairs compatibility
* Orphans attached
* Separators no longer count as items

plugins/calibrecompanion.koplugin/main.lua

@@ -80,7 +80,7 @@ function CalibreCompanion:find_calibre_server()
 end
 
 function CalibreCompanion:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["calibre_wireless_connection"] = {
+    self.ui.menu.menu_items.calibre_wireless_connection = {
         text = _("Calibre wireless connection"),
         sub_item_table = {
             {

plugins/evernote.koplugin/main.lua

@@ -71,7 +71,7 @@ function EvernoteExporter:migrateClippings()
 end
 
 function EvernoteExporter:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["evernote"] = {
+    self.ui.menu.menu_items.evernote = {
         text = _("Evernote"),
         sub_item_table = {
             {

plugins/goodreads.koplugin/main.lua

@@ -23,7 +23,7 @@ function Goodreads:init()
 end
 
 function Goodreads:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["goodreads"] = {
+    self.ui.menu.menu_items.goodreads = {
         text = _("Goodreads"),
         sub_item_table = {
             {

plugins/keepalive.koplugin/main.lua

@@ -68,7 +68,7 @@ function KeepAlive:init()
 end
 
 function KeepAlive:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["keep_alive"] = menuItem
+    self.ui.menu.menu_items.keep_alive = menuItem
 end
 
 return KeepAlive

plugins/kosync.koplugin/main.lua

@@ -86,7 +86,7 @@ function KOSync:onReaderReady()
 end
 
 function KOSync:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["progress_sync"] = {
+    self.ui.menu.menu_items.progress_sync = {
         text = _("Progress sync"),
         sub_item_table = {
             {

plugins/perceptionexpander.koplugin/main.lua

@@ -158,7 +158,7 @@ function PerceptionExpander:showSettingsDialog()
 end
 
 function PerceptionExpander:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["speed_reading_module_perception_expander"] = {
+    self.ui.menu.menu_items.speed_reading_module_perception_expander = {
         text = _("Speed reading module - perception expander"),
         sub_item_table ={
             {

plugins/statistics.koplugin/main.lua

@@ -192,7 +192,7 @@ function ReaderStatistics:updateSettings()
 end
 
 function ReaderStatistics:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["statistics"] = {
+    self.ui.menu.menu_items.statistics = {
         text = _("Statistics"),
         sub_item_table = {
             self:getStatisticEnabledMenuItem(),

plugins/storagestat.koplugin/main.lua

@@ -50,7 +50,7 @@ function StorageStat:init()
 end
 
 function StorageStat:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["storagestat"] = self.menuItem
+    self.ui.menu.menu_items.storagestat = self.menuItem
 end
 
 return StorageStat

plugins/timesync.koplugin/main.lua

@@ -71,7 +71,7 @@ function TimeSync:init()
 end
 
 function TimeSync:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["synchronize_time"] = menuItem
+    self.ui.menu.menu_items.synchronize_time = menuItem
 end
 
 return TimeSync

plugins/zsync.koplugin/main.lua

@@ -25,7 +25,7 @@ function ZSync:init()
 end
 
 function ZSync:addToMainMenu(tab_item_table)
-    self.ui.menu.menu_items["zsync"] = {
+    self.ui.menu.menu_items.zsync = {
         text = _("ZSync"),
         sub_item_table = {
             {