renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ReaderBookmark: fix comparing positions (#10109)

Browse Source
This commit is contained in:
hius07
2023-02-13 01:14:49 +02:00
committed by GitHub
parent db9cb542e4
commit 91ff6ce2d8
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/apps/reader/modules/readerbookmark.lua
View File

@@ -245,13 +245,19 @@ function ReaderBookmark:isBookmarkInPositionOrder(a, b)
if compare_xp then
if compare_xp == 0 then -- both bookmarks with the same start
if a.highlighted and b.highlighted then -- both are highlights, compare ends
return self.ui.document:compareXPointers(a.pos1, b.pos1) < 0
compare_xp = self.ui.document:compareXPointers(a.pos1, b.pos1)
if compare_xp then
return compare_xp < 0
end
logger.warn("Invalid xpointer in highlight:", a.pos1, b.pos1)
return
end
return a.highlighted -- have page bookmarks before highlights
end
return compare_xp < 0
end
-- if compare_xp is nil, some xpointer is invalid and will be sorted first to page 1
logger.warn("Invalid xpointer in highlight:", a.page, b.page)
end
return a_page > b_page
end