From 94c57b9f420984229b86d4375a01bf1dfd116c06 Mon Sep 17 00:00:00 2001 From: cccslater Date: Mon, 9 Sep 2024 20:17:48 +0100 Subject: [PATCH] [NT] Call GotoViewRel for page up/down on useDPadAsActionKeys devices (#12495) Page buttons call `GotoViewRel` again (not `GotoPosRel`). Fixes https://github.com/koreader/koreader/issues/12380 --- frontend/apps/reader/modules/readerpaging.lua | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/apps/reader/modules/readerpaging.lua b/frontend/apps/reader/modules/readerpaging.lua index 68a86a623..a80ebc413 100644 --- a/frontend/apps/reader/modules/readerpaging.lua +++ b/frontend/apps/reader/modules/readerpaging.lua @@ -53,13 +53,13 @@ function ReaderPaging:onGesture() end function ReaderPaging:registerKeyEvents() if Device:hasDPad() and Device:useDPadAsActionKeys() then if G_reader_settings:isTrue("left_right_keys_turn_pages") then - self.key_events.GotoNextPos = { { { "RPgFwd", "LPgFwd", "Right", " " } }, event = "GotoPosRel", args = 1, } - self.key_events.GotoPrevPos = { { { "RPgBack", "LPgBack", "Left" } }, event = "GotoPosRel", args = -1, } + self.key_events.GotoNextPage = { { { "RPgFwd", "LPgFwd", "Right", " " } }, event = "GotoViewRel", args = 1, } + self.key_events.GotoPrevPage = { { { "RPgBack", "LPgBack", "Left" } }, event = "GotoViewRel", args = -1, } elseif G_reader_settings:nilOrFalse("left_right_keys_turn_pages") then self.key_events.GotoNextChapter = { { "Right" }, event = "GotoNextChapter", args = 1, } self.key_events.GotoPrevChapter = { { "Left" }, event = "GotoPrevChapter", args = -1, } - self.key_events.GotoNextPos = { { { "RPgFwd", "LPgFwd", " " } }, event = "GotoPosRel", args = 1, } - self.key_events.GotoPrevPos = { { { "RPgBack", "LPgBack" } }, event = "GotoPosRel", args = -1, } + self.key_events.GotoNextPage = { { { "RPgFwd", "LPgFwd", " " } }, event = "GotoViewRel", args = 1, } + self.key_events.GotoPrevPage = { { { "RPgBack", "LPgBack" } }, event = "GotoViewRel", args = -1, } end elseif Device:hasKeys() then self.key_events.GotoNextPage = { { { "RPgFwd", "LPgFwd", not Device:hasFewKeys() and "Right" } }, event = "GotoViewRel", args = 1, }