renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

InputText: Actually flip the is_keyboard_hidden flag properly

Browse Source 
MultiInputDialog does a close -> show in the same callback,
so if we don't actually keep it in sync with the actual state, we lose
the keyboard and essentially softlock the UI, which is Very Bad(TM).

NOTE: InputDialog has its own keyboard_hidden flag, and it looks...
fairly nightmarish.
This commit is contained in:
NiLuJe
2023-08-13 06:38:45 +02:00
parent 7a5216a0a6
commit 976aaf5f53
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/ui/widget/inputtext.lua
View File

@@ -64,7 +64,7 @@ local InputText = InputContainer:extend{
for_measurement_only = nil, -- When the widget is a one-off used to compute text height for_measurement_only = nil, -- When the widget is a one-off used to compute text height
do_select = false, -- to start text selection do_select = false, -- to start text selection
selection_start_pos = nil, -- selection start position selection_start_pos = nil, -- selection start position
is_keyboard_hidden = false, -- to be able to show the keyboard again when it was hidden is_keyboard_hidden = true, -- to be able to show the keyboard again when it was hidden. (On init, it's the caller's responsibility to call onShowKeyboard, as far as we're concerned, it's hidden)
} }
-- These may be (internally) overloaded as needed, depending on Device capabilities. -- These may be (internally) overloaded as needed, depending on Device capabilities.
@@ -132,9 +132,8 @@ local function initTouchEvents()
if self.parent.onSwitchFocus then if self.parent.onSwitchFocus then
self.parent:onSwitchFocus(self) self.parent:onSwitchFocus(self)
else else
if self.is_keyboard_hidden == true then if self.is_keyboard_hidden then
self:onShowKeyboard() self:onShowKeyboard()
self.is_keyboard_hidden = false
end end
end end
-- zh keyboard with candidates shown here has _frame_textwidget.dimen = nil. -- zh keyboard with candidates shown here has _frame_textwidget.dimen = nil.
@@ -677,8 +676,12 @@ dbg:guard(InputText, "onTextInput",
function InputText:onShowKeyboard(ignore_first_hold_release) function InputText:onShowKeyboard(ignore_first_hold_release)
Device:startTextInput() Device:startTextInput()
self.keyboard.ignore_first_hold_release = ignore_first_hold_release
UIManager:show(self.keyboard) if self.is_keyboard_hidden then
self.keyboard.ignore_first_hold_release = ignore_first_hold_release
UIManager:show(self.keyboard)
self.is_keyboard_hidden = false
end
return true return true
end end