renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Menu: Don't share the dimen object across Menu instances (!)

Browse Source 
The object was never re-assigned, so closing a smaller menu (e.g.,
Calibre metadata search) made the underlying one (e.g., CoverBrowser's
ListMenu) inherit the smaller dimensions...

Instead of creating the object in the Class constructor, create it in the
instance constructor (i.e., :init).

Similar cleanups in other Menu* related classes.
This commit is contained in:
NiLuJe
2021-04-15 02:46:44 +02:00
parent 3274183466
commit 97b81a7eb6
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/ui/widget/touchmenu.lua
View File

@@ -417,7 +417,7 @@ end
TouchMenu widget for hierarchical menus
--]]
local TouchMenu = FocusManager:new{
tab_item_table = {},
tab_item_table = nil, -- mandatory
-- for returning in multi-level menus
item_table_stack = nil,
item_table = nil,