From a5032046d3857fa61be7fa803056ab7dc5b68734 Mon Sep 17 00:00:00 2001 From: Tigran Aivazian Date: Fri, 5 Oct 2012 17:36:43 +0100 Subject: [PATCH] Don't use Home to exit Help page. It is a bad idea to use too many keys for the same function and also do this non-uniformly (i.e. not in all contexts). The info at the bottom of Help screen says "Back to close this page", so only KEY_BACK (but not KEY_HOME) should serve this purpose. And if the user pressed Home twice then the whole application would exit, so using Home here is a bad idea. --- helppage.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helppage.lua b/helppage.lua index 77d8634c0..e2870d919 100644 --- a/helppage.lua +++ b/helppage.lua @@ -116,7 +116,7 @@ function HelpPage:show(ypos, height, commands, title) self.page = self.page - 1 is_pagedirty = true end - elseif ev.code == KEY_BACK or ev.code == KEY_HOME then + elseif ev.code == KEY_BACK then return nil end end