renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

MenuSorter: fix outside testability (for potential unit tests)

Browse Source
This commit is contained in:
Frans de Jonge
2017-03-04 14:46:38 +01:00
parent 653ff64438
commit a970a1f034
27 changed files with 58 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/apps/reader/modules/readerpaging.lua
View File

@@ -181,7 +181,7 @@ function ReaderPaging:getLastPercent()
end
end
function ReaderPaging:addToMainMenu(tab_item_table)
function ReaderPaging:addToMainMenu(menu_items)
-- FIXME: repeated code with page overlap menu for readerrolling
-- needs to keep only one copy of the logic as for the DRY principle.
-- The difference between the two menus is only the enabled func.
@@ -201,7 +201,7 @@ function ReaderPaging:addToMainMenu(tab_item_table)
for _, menu_entry in ipairs(self.view:genOverlapStyleMenu()) do
table.insert(page_overlap_menu, menu_entry)
end
self.ui.menu.menu_items.page_overlap = {
menu_items.page_overlap = {
text = _("Page overlap"),
enabled_func = function()
return not self.view.page_scroll and self.zoom_mode ~= "page"
@@ -209,7 +209,7 @@ function ReaderPaging:addToMainMenu(tab_item_table)
end,
sub_item_table = page_overlap_menu,
}
self.ui.menu.menu_items.read_from_right_to_left = {
menu_items.read_from_right_to_left = {
text = _("Read from right to left"),
checked_func = function() return self.inverse_reading_order end,
callback = function()