From b2e1d9dc42a3073024faf9105913869e7603da42 Mon Sep 17 00:00:00 2001 From: Qingping Hou Date: Sun, 13 Nov 2016 00:06:54 -0800 Subject: [PATCH] dictquicklookup(chore): simplify logic that disables wikipedia button --- frontend/ui/widget/dictquicklookup.lua | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/frontend/ui/widget/dictquicklookup.lua b/frontend/ui/widget/dictquicklookup.lua index 157628a2d..ea100734f 100644 --- a/frontend/ui/widget/dictquicklookup.lua +++ b/frontend/ui/widget/dictquicklookup.lua @@ -27,7 +27,6 @@ local Blitbuffer = require("ffi/blitbuffer") Display quick lookup word definition ]] local DictQuickLookup = InputContainer:new{ - wikipedia_button = true, results = nil, lookupword = nil, dictionary = nil, @@ -187,7 +186,7 @@ function DictQuickLookup:update() { { text = _("Wikipedia"), - enabled = self:isWikipediaActive(), + enabled = not self.wiki, callback = function() UIManager:scheduleIn(0.1, function() self:lookupWikipedia() @@ -273,7 +272,6 @@ function DictQuickLookup:update() self.dict_frame, } } - self:nextWikipediaStatus() UIManager:setDirty("all", function() local update_region = self.dict_frame.dimen:combine(orig_dimen) DEBUG("update dict region", update_region) @@ -311,18 +309,6 @@ function DictQuickLookup:getHighlightText() end end -function DictQuickLookup:nextWikipediaStatus() - if self.wikipedia_button then - DictQuickLookup.wikipedia_button = false - else - DictQuickLookup.wikipedia_button = true - end -end - -function DictQuickLookup:isWikipediaActive() - return self.wikipedia_button -end - function DictQuickLookup:isPrevDictAvaiable() return self.dict_index > 1 end @@ -396,7 +382,6 @@ function DictQuickLookup:onTapCloseDict(arg, ges_ev) end function DictQuickLookup:onClose() - self:nextWikipediaStatus() UIManager:close(self) for i = #self.window_list, 1, -1 do local window = self.window_list[i]