MenuSorter: review comments and various bug fixes

* fixed wrongful retention of submenus variable and added return to MenuSorter:findById
* fixed readerfooter_spec.lua error
* fixed review comments
This commit is contained in:
Frans de Jonge
2017-03-03 07:41:10 +01:00
parent aa0bf60ccb
commit b7b5950e98
23 changed files with 133 additions and 129 deletions

View File

@@ -201,7 +201,7 @@ function ReaderPaging:addToMainMenu(tab_item_table)
for _, menu_entry in ipairs(self.view:genOverlapStyleMenu()) do
table.insert(page_overlap_menu, menu_entry)
end
self.ui.menu.menu_items["page_overlap"] = {
self.ui.menu.menu_items.page_overlap = {
text = _("Page overlap"),
enabled_func = function()
return not self.view.page_scroll and self.zoom_mode ~= "page"
@@ -209,7 +209,7 @@ function ReaderPaging:addToMainMenu(tab_item_table)
end,
sub_item_table = page_overlap_menu,
}
self.ui.menu.menu_items["read_from_right_to_left"] = {
self.ui.menu.menu_items.read_from_right_to_left = {
text = _("Read from right to left"),
checked_func = function() return self.inverse_reading_order end,
callback = function()