renun/koreader
1
0
Fork 0
mirror of https://github.com/koreader/koreader.git synced 2025-08-10 00:52:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

css_tweaks: add generic setting for smaller inpage footnotes (#13613)

Browse Source 
Replaces the 3 '... (smaller)' tweaks.
This commit is contained in:
Benedikt McMullin
2025-06-01 20:03:24 +02:00
committed by GitHub
parent 521401c113
commit cfc67797e2
3 changed files with 91 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
frontend/ui/data/settings_migration.lua
View File

@@ -45,6 +45,62 @@ function SettingsMigration:migrateSettings(config)
config:saveSetting("copt_word_spacing", { 100, space_condensing })
end
if config:has("style_tweaks") then
local tweaks = config:readSetting("style_tweaks")
if tweaks then
-- try to preserve user intent when flattening the previous combination of
-- ["footnote-inpage_x", "footnote-inpage_x_smaller"] into ["footnote-inpage_x"]
--
-- | x_smaller |
-- | nil | true | false |
-- -----------+-------+-------+-------+
-- nil | nil | true | false |
-- x true | true | true | true |
-- false | false | true | false |
-- -----------+-----------------------+
--
-- If either tweak is true, enable the base tweak to keep that type of footnote.
-- (Preserving small vs normal size is handled below)
-- If one was false and the other nil or also false, we had a default
-- that was disabled for the current book and want to keep it false.
-- If both are nil they were both disabled (global settings) or both using their
-- respective default values (book settings) and we keep it as nil
if tweaks["footnote-inpage_epub"] or tweaks["footnote-inpage_epub_smaller"] then
tweaks["footnote-inpage_epub"] = true
elseif tweaks["footnote-inpage_epub"] == false or tweaks["footnote-inpage_epub_smaller"] == false then
tweaks["footnote-inpage_epub"] = false
end
if tweaks["footnote-inpage_wikipedia"] or tweaks["footnote-inpage_wikipedia_smaller"] then
tweaks["footnote-inpage_wikipedia"] = true
elseif tweaks["footnote-inpage_wikipedia"] == false or tweaks["footnote-inpage_wikipedia_smaller"] == false then
tweaks["footnote-inpage_wikipedia"] = false
end
if tweaks["footnote-inpage_classic_classnames"] or tweaks["footnote-inpage_classic_classnames_smaller"] then
tweaks["footnote-inpage_classic_classnames"] = true
elseif tweaks["footnote-inpage_classic_classnames"] == false or tweaks["footnote-inpage_classic_classnames_smaller"] == false then
tweaks["footnote-inpage_classic_classnames"] = false
end
local forced_size = false
for __, pct in ipairs( { 100, 90, 85, 80, 75, 70, 65 } ) do
if tweaks["inpage_footnote_font-size_" .. pct] then
forced_size = true
end
end
if not forced_size
and (tweaks["footnote-inpage_epub_smaller"]
or tweaks["footnote-inpage_wikipedia_smaller"]
or tweaks["footnote-inpage_classic_classnames_smaller"]
) then
tweaks["inpage_footnote_font-size_smaller"] = true
end
tweaks["footnote-inpage_epub_smaller"] = nil
tweaks["footnote-inpage_wikipedia_smaller"] = nil
tweaks["footnote-inpage_classic_classnames_smaller"] = nil
end
end
end
return SettingsMigration